Enable PYTHONWARNDEFAULTENCODING=1 and fix violations#10935
Enable PYTHONWARNDEFAULTENCODING=1 and fix violations#10935Zac-HD merged 4 commits intopytest-dev:mainfrom
PYTHONWARNDEFAULTENCODING=1 and fix violations#10935Conversation
Zac-HD
changed the title
PYTHONWARNDEFAULTENCODING=1 and fix violations
Zac-HD
force-pushed
the
10328
branch
6 times, most recently
from
3c6606e to
fa9c498
Compare
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Nice work, I didn't think anyone would have the endurance to do this one :)
I suggest merging this quickly to avoid conflicts and regressions.
There was a problem hiding this comment.
Amazing work, thanks @Zac-HD and @nondescryptid! I noticed a couple of small things, but I agree we should aim to merge this quickly (and I'm looking forward to turning this warning on for my own project finally!).
Zac-HD
force-pushed
the
10328
branch
2 times, most recently
from
8841734 to
f6b995e
Compare
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Thanks again! IMHO this deserves its own changelog entry to make downstream projects aware that they can now use this, but that could be done in a follow up PR too.
|
Oh my goodness. @The-Compiler So sorry about not responding earlier to your request for changes. I didn't receive notifications for this and only realised this had been merged when I was looking through my account's commit history and wondered why I had a commit to pytest. Massive thanks to you, @bluetech and @Zac-HD! |
|
All good, no worries! We got it all merged, and it still was a good starting point :) |
4 participants
Updated attempt to check encoding warnings as in #10328, as dependencies have been updated in the past 6 months.
(Zac edit: now also fixes #7781)