Don't require script headers in Rebol and Red codes.#2349
Merged
birkenfeld merged 4 commits intopygments:masterfrom Feb 24, 2023
Merged
Don't require script headers in Rebol and Red codes.#2349birkenfeld merged 4 commits intopygments:masterfrom
birkenfeld merged 4 commits intopygments:masterfrom
Conversation
Member
|
The header should still be highlighted in some way if present I suppose? |
Contributor
|
Yeah, you probably just want to add a rule |
Contributor
Author
|
@birkenfeld unfortunately as there is no way to find out if the code is a complete script or just a snipped of it, the header may not be highlighted how it was. Because one could have such an input: switch language [
Rebol [ print "bla" ]
Perl [ print "foo" ]
]It is currently also broken. But as the header is just an ordinary Rebol data, it will be highlighted too... the only difference is, that what is before header in a complete script will not be handled like a comment. |
Member
|
OK, makes sense. Just one nit: please remove the unneeded code instead of commenting. |
Contributor
Author
|
@birkenfeld the code is removed now. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2348