lean: correctly parse expressions nested within attributes #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
May 25, 2021
Contributor
Author
|
CI failure is unrelated to this change. |
jeanas
approved these changes
Mar 8, 2022
Contributor
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
LGTM. Could you rebase this on top of master? There was a breaking change in the CI.
Contributor
Author
|
Sorry, I totally forgot about this. I've resolved conflicts with the latest master. |
jeanas
approved these changes
Apr 20, 2023
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the syntax fix made in leanprover/vscode-lean#265