Skip to content

Conversation

@SharathHuddar
Copy link

@SharathHuddar SharathHuddar commented Jul 2, 2023

Change Summary

Importing create_model in tools.py through relative path instead of absolute path - so that _get_parsing_type doesn't import V2 code when copied over to main (V2) branch

Related issue number

fix #6361

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@SharathHuddar SharathHuddar changed the base branch from main to 1.10.X-fixes July 2, 2023 15:01
@SharathHuddar SharathHuddar marked this pull request as ready for review July 2, 2023 15:01
@SharathHuddar
Copy link
Author

please review

@adriangb adriangb enabled auto-merge (squash) July 2, 2023 17:51
@adriangb adriangb disabled auto-merge July 2, 2023 17:52
@adriangb adriangb enabled auto-merge (squash) July 2, 2023 17:52
@hramezani hramezani closed this Jul 2, 2023
auto-merge was automatically disabled July 2, 2023 21:51

Pull request was closed

@hramezani hramezani reopened this Jul 2, 2023
@hramezani hramezani merged commit 2c0e2a6 into pydantic:1.10.X-fixes Jul 2, 2023
@hramezani
Copy link
Member

Thanks @SharathHuddar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pydantic.v1.parse_obj_as internally uses pydantic.main.create_model instead of pydantic.v1.main.create_model

3 participants