Remove dead code checking union/intersection types length #18396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fisker
commented
Dec 1, 2025
| case "TSIntersectionType": | ||
| if ( | ||
| (isUnionType(parent) || isIntersectionType(parent)) && | ||
| parent.types.length > 1 && |
Member
Author
There was a problem hiding this comment.
union/intersection always have multiple types.
fisker
commented
Dec 1, 2025
| if ( | ||
| (isUnionType(parent) || isIntersectionType(parent)) && | ||
| parent.types.length > 1 && | ||
| (!node.types || node.types.length > 1) |
Member
Author
There was a problem hiding this comment.
!node.type matches node above that fallthrough, node.types.length > 1 matches union/intersection, so it's always true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's dead code because we always unwrap single types.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.