fix(oxlint): current dir as arg #9382
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
my windows setup is broken. |
|
|
BenShelton
changed the title
BenShelton
force-pushed
the
fix-current-dir-arg
branch
from
a9284da to
2ce2ec2
Compare
|
Ok so using If that's still problematic I think we'd have to use a crate like normalize_path instead. Or manually handle each edge case. |
|
@Boshen what was the reason of marking it as a draft? |
Boshen
force-pushed
the
fix-current-dir-arg
branch
from
ba7ec72 to
7bd5c00
Compare
4 participants
closes #9023
When passing
.as an arg it would result in a path like{cwd}/., which when being used to resolve other paths obviously caused issues. This canonicalizes any path args before doing anything else.Adds test to verify this based on original issue. This also caused another snapshot to change for an invalid file extension, changing from
LintSucceededtoLintNoFilesFound, which I believe is actually correct? If you only pass files that do not exist it would make more sense to return an error to me so I'm viewing this as a side effect fix.