Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jun 8, 2025

No description provided.

@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Jun 8, 2025
Copy link
Member Author

Sysix commented Jun 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jun 8, 2025
@Sysix Sysix changed the title perf(language_server): transform MessageWithPosition to Diagnostics with less allocations perf(language_server): transform MessageWithPosition to Diagnostic with less allocations Jun 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 8, 2025

CodSpeed Instrumentation Performance Report

Merging #11561 will degrade performances by 11.11%

Comparing 06-08-perf_language_server_transform_messagewithposition_to_diagnostics_with_less_allocations (7bf25cb) with main (6d68568)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -11.11%

@Sysix Sysix marked this pull request as ready for review June 8, 2025 21:49
@Sysix Sysix requested a review from camc314 as a code owner June 8, 2025 21:49
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 9, 2025
Copy link
Contributor

camc314 commented Jun 9, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 06-08-perf_language_server_transform_messagewithposition_to_diagnostics_with_less_allocations branch from 508989d to 7bf25cb Compare June 9, 2025 09:36
@graphite-app graphite-app bot merged commit 7bf25cb into main Jun 9, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 06-08-perf_language_server_transform_messagewithposition_to_diagnostics_with_less_allocations branch June 9, 2025 09:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants