Skip to content

refactor(linter): use one instance of rope per file #11552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Jun 8, 2025
Merged

refactor(linter): use one instance of rope per file #11552

graphite-app merged 1 commit into from
Jun 8, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jun 8, 2025

No description provided.

@Sysix Graphite App
Copy link
Member Author

Sysix commented Jun 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 8, 2025
@Sysix Sysix force-pushed the 06-08-refactor_linter_use_one_instance_of_rope_per_file branch from 2816efa to aeb2f1a Compare June 8, 2025 12:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 8, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11552 will not alter performance

Comparing 06-08-refactor_linter_use_one_instance_of_rope_per_file (9b475ad) with main (cb17dae)

Summary

✅ 38 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review June 8, 2025 12:24
@Sysix Sysix requested a review from camc314 as a code owner June 8, 2025 12:24
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 8, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jun 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 06-08-refactor_linter_use_one_instance_of_rope_per_file branch from aeb2f1a to 9b475ad Compare June 8, 2025 12:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 8, 2025
@graphite-app graphite-app bot merged commit 9b475ad into main Jun 8, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 06-08-refactor_linter_use_one_instance_of_rope_per_file branch June 8, 2025 12:42
taearls pushed a commit to taearls/oxc that referenced this pull request Jun 8, 2025
@Sysix @taearls
refactor(linter): use one instance of rope per file (oxc-project#11552)
87645bd
@oxc-bot oxc-bot mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314