Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 6, 2025

fixes #4868

Copy link
Contributor Author

camc314 commented Jun 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI C-enhancement Category - New feature or request labels Jun 6, 2025
@camc314 camc314 marked this pull request as ready for review June 6, 2025 14:01
@camc314 camc314 force-pushed the c/06-06-feat_linter_add_more_info_to_json_reporter branch from df5d424 to 6639e59 Compare June 6, 2025 14:05
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Instrumentation Performance Report

Merging #11524 will improve performances by 5.81%

Comparing c/06-06-feat_linter_add_more_info_to_json_reporter (bd9dd88) with main (7430b14)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 2.9 ms +5.81%

@camc314 camc314 requested a review from Sysix June 6, 2025 14:07
@camc314 camc314 force-pushed the c/06-06-feat_linter_add_more_info_to_json_reporter branch from 6639e59 to af6399c Compare June 6, 2025 14:18
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change for someone using --json in CI or in another way.
Changes looks good to me. Tests are still failing :)

@camc314 camc314 changed the title feat(linter): add more info to json reporter feat(linter)!: add more info to json reporter Jun 6, 2025
@camc314
Copy link
Contributor Author

camc314 commented Jun 6, 2025

This would be a breaking change for someone using --json in CI or in another way. Changes looks good to me. Tests are still failing :)

yeah i wanted to get this in before 1.0, after 1.0 we can try to avoid the breaks
I've update the title to mark this as a breaking cha so (hopefully) those people using this will see it in the release notes

@camc314 camc314 force-pushed the c/06-06-feat_linter_add_more_info_to_json_reporter branch from af6399c to a39a5d1 Compare June 6, 2025 14:20
@camc314 camc314 added the A-linter Area - Linter label Jun 6, 2025
@camc314
Copy link
Contributor Author

camc314 commented Jun 6, 2025

closes #4868

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 6, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-06-feat_linter_add_more_info_to_json_reporter branch from a39a5d1 to bd9dd88 Compare June 6, 2025 14:29
@graphite-app graphite-app bot merged commit bd9dd88 into main Jun 6, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 6, 2025
@graphite-app graphite-app bot deleted the c/06-06-feat_linter_add_more_info_to_json_reporter branch June 6, 2025 14:36
This was referenced Jun 6, 2025
camc314 added a commit that referenced this pull request Jun 6, 2025
## [0.18.0] - 2025-06-06

- bd9dd88 linter: [**BREAKING**] Add more info to json reporter (#11524)
(camc314)

### Features

- 825d40c linter: Fix casing in
unicorn/no-useless-promise-resolve-reject (#11528) (camc314)
- 2faee3d linter: Fix grammer in react/exhaustive-deps (#11527)
(camc314)

### Bug Fixes

- 1a71d7c linter: Misplaced backtick in unicorn/no-array-for-each
diagnostic (#11529) (camc314)
- 7430b14 linter: Grammer in jest/valid-expect diagnostic (#11522)
(camc314)
- b92ac41 linter: Grammer in eslint/no-redeclare diagnostic (#11521)
(camc314)
- 17883e3 linter: Improve eslint/no-unsafe-negation diagnostic (#11520)
(camc314)
- 8c89937 linter: Improve eslint/no-shadow-restricted-names diagnostic
(#11519) (camc314)
- 3f0d889 linter: Add missing article to
oxc/bad-array-method-on-arguments diagnostic (#11518) (camc314)
- cf0c24c linter: Improve message in react/prefer-es6-class diagnostic
(#11516) (camc314)
- 91855df linter: Fix message in react/rules-of-hooks diagnostic
(#11515) (camc314)
- b272194 linter: Misplaced backtick in jest/no-conditional-expect
diagnostic (#11514) (camc314)
- 3403303 linter: Misplaced backtick in unicorn/prefer-dom-node-dataset
diagnostic (#11513) (camc314)
- d5ca872 linter: Misplaced backtick in eslint/radix diagnostic (#11512)
(camc314)
- 2dcf8be linter: Improve diagnostic message when function name is
referenced (#11509) (camc314)
- 0de0c9c linter: Improve diagnostic message for
no-unsafe-declaration-merging (#11508) (camc314)
- 0946dac linter: Correctly inherit categories when plugins are enabled
(#11353) (Cameron)
- 510c1c6 linter: Add missing `allowArrowFunctions` option for
eslint/func-style (#11455) (yefan)
- c77787c linter: Improve `eslint/no-loss-of-precision` (#11437)
(magic-akari)
- 11d4523 linter: False positive in react/exhaustive-deps (#11438)
(camc314)
- 616b613 linter/switch-case-braces: Align the logic with `unicorn`
(#11405) (shulaoda)

### Refactor

- db0b099 language_server: Convert only once uri to path when creating
`ServerLinter` (#11503) (Sysix)
- ccceb52 language_server: Simplify `workspace/didChangeConfiguration`
call (#11462) (Sysix)
- 0fdc51e linter: Simplify `OxlintRules::override_rules` (#11510)
(camc314)

### Testing

- 2ba2893 editor: Fix test for auto `fixAll` on save (#11448) (Sysix)

Co-authored-by: camc314 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for Enhanced JSON Output in Reporter

3 participants