fix(linter): remove use of FrameworkFlags::React to decide whether rules should run
#11383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11383 will improve performances by 4.37%Comparing Summary
Benchmarks breakdown
|
camc314
force-pushed
the
c/05-29-fix_linter_remove_react_from_default_plugin_set
branch
from
de1053f to
8b77451
Compare
camc314
force-pushed
the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
2 times, most recently
from
4935286 to
1a8790c
Compare
Sysix
approved these changes
May 30, 2025
camc314
force-pushed
the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
from
1a8790c to
7da2ff0
Compare
graphite-app
bot
changed the base branch from
c/05-29-fix_linter_remove_react_from_default_plugin_set
to
graphite-base/11383
graphite-app
bot
force-pushed
the
graphite-base/11383
branch
from
8b77451 to
ead5309
Compare
graphite-app
bot
force-pushed
the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
from
7da2ff0 to
33f9c12
Compare
graphite-app
bot
force-pushed
the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
from
33f9c12 to
f0fb065
Compare
Contributor
Author
Merge activity
|
…rules should run (#11383) As mentioned in the PR above this in the stack, we never populate this value, so rules relying on framework flags that aren't the `Jest`/`Vitest` just don't work.
graphite-app
bot
force-pushed
the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
from
f0fb065 to
25ecbfe
Compare
graphite-app
bot
deleted the
c/05-29-fix_linter_remove_use_of_frameworkflags_react_to_decide_whether_rules_should_run
branch
camc314
added a commit
that referenced
this pull request
May 30, 2025
## [0.17.0] - 2025-05-30 - ead5309 linter: [**BREAKING**] Remove react from default plugin set (#11382) (camc314) ### Features - 2d25bd8 linter: Remove `unicorn/no-for-loop` over `typescript/prefer-for-of` (#11354) (camc314) - bbb7eb1 linter: Add auto-fix to react/forward-ref-uses-ref (#11342) (yefan) - 590c27b linter: Add auto-fix to unicorn/no-await-expression-member (#11306) (yefan) - 7824f01 linter: Implement suggestion for `jsx/no-useless-fragment` (#10800) (Cam McHenry) - 2083d33 linter/language_server: Add second editor suggestion for `react/forward-ref-uses-ref` (#11375) (Sysix) ### Bug Fixes - f6424dd linter: Reflect react plugin is disabled by default in cli (#11397) (camc314) - 25ecbfe linter: Remove use of `FrameworkFlags::React` to decide whether rules should run (#11383) (camc314) - 0d240e4 linter: False positive in react/exhaustive-deps with default formal parameter (#11395) (camc314) - c91697e linter: Fix panic in multi byte char in `TryFrom` aria (#11350) (camc314) - 9798ef1 linter: Stack overflow in no-async-endpoint-handlers (#11317) (camc314) - 348ad97 linter: Skip no-unused-vars on astro files (#11303) (camc314) - 183d7f0 linter: Make `jest/no-large-snapshots` error easier to comprehend (#11294) (Ulrich Stark) - 4e606a5 linter: Improve `jest/no-large-snapshots` (#11291) (Ulrich Stark) - 14f790f linter: Improve `jest/no-restricted-matchers` (#11292) (Ulrich Stark) - a2c82be linter/block-scoped-var: Better diagnostic messages (#11290) (DonIsaac) - 19772e5 linter/no-unused-vars: Panic when variable is redeclared as function in same scope (#11280) (Dunqing) - 7af5bb1 oxc_language_server: Include save option for text document sync capability (#11297) (Nicholas Rayburn) ### Performance - 0ed6c1a language_server: Use `Arc<RwLock>` instead of `Mutex` for workspace workers (#11328) (Sysix) - a0ee946 linter: Reduce code size in `globals` (#11333) (shulaoda) - c90c5e9 linter/no-unused-vars: Simplify checking self call usage (#11281) (Dunqing) ### Documentation - eae51ca linter: Clarify jsdoc/check-tag-names configuration (#11394) (Rägnar O'ock) - cd354d4 oxlint: Remove incorrect doc comment (#11326) (camc314) ### Refactor - 42738f0 linter: Shorten code of match arms (#11389) (Ulrich Stark) - 8a34447 linter: Improve `unicorn/text-encoding-identifier-case` (#11386) (shulaoda) - eaa605e linter: Avoid some `Arc::clone` in linter runtime (#11388) (Boshen) - 1cd8b9c linter: Fixes in `react/forward-ref-uses-ref` are suggestions (#11376) (Sysix) - 50ef691 linter: Add `diagnostics_with_multiple_fixes` to `LintContext` (#11357) (Sysix) - 606bb34 linter: Accept `PossibleFixes` instead of `Fix` for `Messages` (#11295) (Sysix) - 042a3f3 linter: Use `PossibleFixes` instead of `Option<Fix>` (#11284) (Sysix) - ffcfb46 linter: Improve `unicorn/throw-new-error` (#11364) (shulaoda) - 8fb55c3 linter: Cleanup docs and simplify code of `eslint/no-fallthrough` (#11331) (Ulrich Stark) - e2f0f0a linter: Improve docs and simplify code of `eslint/no-duplicate-imports` (#11320) (Ulrich Stark) - b53b053 linter: Simplify accessing span of NameSpan (#11305) (Ulrich Stark) - 4bc2650 linter: Improve `eslint/no-void` (#11285) (shulaoda) ### Styling - 49b664c linter: Remove needless newline in `declare_oxc_lint` (#11400) (camc314) ### Testing - c4f64aa linter: Explicitly disable correctness for clarity (#11327) (camc314) - a404b2c linter: `eslint/no-duplicate-imports` shouldn't report the same span (#11324) (Ulrich Stark) Co-authored-by: camc314 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the PR above this in the stack, we never populate this value, so rules relying on framework flags that aren't the
Jest/Vitestjust don't work.