Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 29, 2025

feat-second-editor-suggestion

closes #9561

blocked by #11379

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels May 29, 2025
Copy link
Member Author

Sysix commented May 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Instrumentation Performance Report

Merging #11375 will improve performances by 29.33%

Comparing 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ (2083d33) with main (25ecbfe)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 2.7 ms +29.33%

@Sysix Sysix changed the base branch from main to graphite-base/11375 May 29, 2025 16:08
@Sysix Sysix force-pushed the graphite-base/11375 branch from 03e8aa9 to 39ccfee Compare May 29, 2025 16:09
@Sysix Sysix force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch from 4a36cb0 to a440ea4 Compare May 29, 2025 16:09
@Sysix Sysix changed the base branch from graphite-base/11375 to 05-29-refactor_linter_fixes_in_react_forward-ref-uses-ref_are_suggestions May 29, 2025 16:09
@graphite-app graphite-app bot changed the base branch from 05-29-refactor_linter_fixes_in_react_forward-ref-uses-ref_are_suggestions to graphite-base/11375 May 29, 2025 16:21
@graphite-app graphite-app bot force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch from a440ea4 to 6716fa7 Compare May 29, 2025 16:25
@graphite-app graphite-app bot force-pushed the graphite-base/11375 branch from 39ccfee to 1cd8b9c Compare May 29, 2025 16:25
@graphite-app graphite-app bot changed the base branch from graphite-base/11375 to main May 29, 2025 16:25
@graphite-app graphite-app bot force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch from 6716fa7 to fbae44d Compare May 29, 2025 16:25
@Sysix Sysix force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch 5 times, most recently from 5164eb9 to d750497 Compare May 30, 2025 09:38
@Sysix Sysix marked this pull request as ready for review May 30, 2025 10:20
@Sysix Sysix requested a review from camc314 as a code owner May 30, 2025 10:20
@Sysix Sysix force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch from d750497 to cb08eef Compare May 30, 2025 11:20
@Sysix Sysix force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch 2 times, most recently from 2eaff87 to 6bbba10 Compare May 30, 2025 15:11
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 30, 2025
Copy link
Member Author

Sysix commented May 30, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch from 6bbba10 to 2083d33 Compare May 30, 2025 15:15
@graphite-app graphite-app bot merged commit 2083d33 into main May 30, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-29-feat_linter_language_server_add_second_editor_suggestion_for_react_forward-ref-uses-ref_ branch May 30, 2025 15:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 30, 2025
camc314 added a commit that referenced this pull request May 30, 2025
## [0.17.0] - 2025-05-30

- ead5309 linter: [**BREAKING**] Remove react from default plugin set
(#11382) (camc314)

### Features

- 2d25bd8 linter: Remove `unicorn/no-for-loop` over
`typescript/prefer-for-of` (#11354) (camc314)
- bbb7eb1 linter: Add auto-fix to react/forward-ref-uses-ref (#11342)
(yefan)
- 590c27b linter: Add auto-fix to unicorn/no-await-expression-member
(#11306) (yefan)
- 7824f01 linter: Implement suggestion for `jsx/no-useless-fragment`
(#10800) (Cam McHenry)
- 2083d33 linter/language_server: Add second editor suggestion for
`react/forward-ref-uses-ref` (#11375) (Sysix)

### Bug Fixes

- f6424dd linter: Reflect react plugin is disabled by default in cli
(#11397) (camc314)
- 25ecbfe linter: Remove use of `FrameworkFlags::React` to decide
whether rules should run (#11383) (camc314)
- 0d240e4 linter: False positive in react/exhaustive-deps with default
formal parameter (#11395) (camc314)
- c91697e linter: Fix panic in multi byte char in `TryFrom` aria
(#11350) (camc314)
- 9798ef1 linter: Stack overflow in no-async-endpoint-handlers (#11317)
(camc314)
- 348ad97 linter: Skip no-unused-vars on astro files (#11303) (camc314)
- 183d7f0 linter: Make `jest/no-large-snapshots` error easier to
comprehend (#11294) (Ulrich Stark)
- 4e606a5 linter: Improve `jest/no-large-snapshots` (#11291) (Ulrich
Stark)
- 14f790f linter: Improve `jest/no-restricted-matchers` (#11292) (Ulrich
Stark)
- a2c82be linter/block-scoped-var: Better diagnostic messages (#11290)
(DonIsaac)
- 19772e5 linter/no-unused-vars: Panic when variable is redeclared as
function in same scope (#11280) (Dunqing)
- 7af5bb1 oxc_language_server: Include save option for text document
sync capability (#11297) (Nicholas Rayburn)

### Performance

- 0ed6c1a language_server: Use `Arc<RwLock>` instead of `Mutex` for
workspace workers (#11328) (Sysix)
- a0ee946 linter: Reduce code size in `globals` (#11333) (shulaoda)
- c90c5e9 linter/no-unused-vars: Simplify checking self call usage
(#11281) (Dunqing)

### Documentation

- eae51ca linter: Clarify jsdoc/check-tag-names configuration (#11394)
(Rägnar O'ock)
- cd354d4 oxlint: Remove incorrect doc comment (#11326) (camc314)

### Refactor

- 42738f0 linter: Shorten code of match arms (#11389) (Ulrich Stark)
- 8a34447 linter: Improve `unicorn/text-encoding-identifier-case`
(#11386) (shulaoda)
- eaa605e linter: Avoid some `Arc::clone` in linter runtime (#11388)
(Boshen)
- 1cd8b9c linter: Fixes in `react/forward-ref-uses-ref` are suggestions
(#11376) (Sysix)
- 50ef691 linter: Add `diagnostics_with_multiple_fixes` to `LintContext`
(#11357) (Sysix)
- 606bb34 linter: Accept `PossibleFixes` instead of `Fix` for `Messages`
(#11295) (Sysix)
- 042a3f3 linter: Use `PossibleFixes` instead of `Option<Fix>` (#11284)
(Sysix)
- ffcfb46 linter: Improve `unicorn/throw-new-error` (#11364) (shulaoda)
- 8fb55c3 linter: Cleanup docs and simplify code of
`eslint/no-fallthrough` (#11331) (Ulrich Stark)
- e2f0f0a linter: Improve docs and simplify code of
`eslint/no-duplicate-imports` (#11320) (Ulrich Stark)
- b53b053 linter: Simplify accessing span of NameSpan (#11305) (Ulrich
Stark)
- 4bc2650 linter: Improve `eslint/no-void` (#11285) (shulaoda)

### Styling

- 49b664c linter: Remove needless newline in `declare_oxc_lint` (#11400)
(camc314)

### Testing

- c4f64aa linter: Explicitly disable correctness for clarity (#11327)
(camc314)
- a404b2c linter: `eslint/no-duplicate-imports` shouldn't report the
same span (#11324) (Ulrich Stark)

Co-authored-by: camc314 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: supports multiple editor suggestions for single rule

3 participants