Skip to content

perf(language_server): do not request for configuration when all workers are ready #10897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 8, 2025
Merged

perf(language_server): do not request for configuration when all workers are ready #10897

graphite-app merged 1 commit into from
May 8, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 8, 2025

No description provided.

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance labels May 8, 2025
@Sysix Sysix marked this pull request as ready for review May 8, 2025 13:38
@Sysix Sysix requested a review from camc314 as a code owner May 8, 2025 13:38
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented May 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 05-08-perf_language_server_do_not_request_for_configuration_when_all_workers_are_ready branch from 794c1bf to 00ffbc9 Compare May 8, 2025 13:41
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10897 will not alter performance

Comparing 05-08-perf_language_server_do_not_request_for_configuration_when_all_workers_are_ready (00ffbc9) with main (7d09973)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 00ffbc9 into main May 8, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@graphite-app graphite-app bot deleted the 05-08-perf_language_server_do_not_request_for_configuration_when_all_workers_are_ready branch May 8, 2025 13:44
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314