refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` #10890

Sysix · 2025-05-08T11:51:12Z

This PR introduces a new Options structure, which will be used for initialize and workspace/didChangeConfiguration.
This is needed for multi workspace support, or else we will do the less performance-way with sending a server-request to the client.

Updated the docs to reflect how to use the new configuration structure
Still used the old structure as a fallback, because the IntelliJ plugin ❤️

Sysix · 2025-05-08T11:51:27Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-05-08T11:54:14Z

CodSpeed Instrumentation Performance Report

Merging #10890 will not alter performance

_{Comparing 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ (3cc1466) with main (bd2ef7d)}

Summary

✅ 36 untouched benchmarks

crates/oxc_language_server/README.md

Sysix · 2025-05-08T13:44:28Z

@nrayburn-tech I tested it with VSCode extension in main and the language server in this PR.
Everything should still work for the IntelliJ Plugin.
Could you guys start using the new format so we can remove the fallbacks in the future ❤️ ?

crates/oxc_language_server/README.md

crates/oxc_language_server/src/main.rs

nrayburn-tech · 2025-05-09T12:27:43Z

@nrayburn-tech I tested it with VSCode extension in main and the language server in this PR. Everything should still work for the IntelliJ Plugin. Could you guys start using the new format so we can remove the fallbacks in the future ❤️ ?

I haven’t tested or reviewed anything, but I don’t think migrating should be difficult if I just need to change the input arguments to the initialize command.

Sysix · 2025-05-11T14:30:20Z

I wanted to wait for all PRs to be approved.
This change should be in main / next release as fast as possible → merging

Sysix · 2025-05-11T14:30:31Z

Merge activity

May 11, 10:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 11, 10:30 AM EDT: Sysix added this pull request to the Graphite merge queue.
May 11, 10:34 AM EDT: Merged by the Graphite merge queue.

…e` and `workspace/didChangeConfiguration` (#10890) This PR introduces a new Options structure, which will be used for `initialize` and `workspace/didChangeConfiguration`. This is needed for multi workspace support, or else we will do the less performance-way with sending a server-request to the client. Updated the docs to reflect how to use the new configuration structure Still used the old structure as a fallback, because the IntelliJ plugin ❤️

## [0.16.11] - 2025-05-16 ### Features - 078bf0b language_server: Better fallback handling when passing invalid `Options` values (#10930) (Sysix) - be7f7e1 language_server/editor: Support multi workspace folders (#10875) (Sysix) - eef93b4 linter: Add import/no-unassigned-import (#10970) (yefan) - cc0112f linter: No-unused-vars add setting for `reportVarsOnlyUsedAsTypes` (#11009) (camc314) - 17e49c3 linter: Implement configuration and checking loops for `eslint/no_constant_condition` (#10949) (Ulrich Stark) - 21117ac linter: Implement react/forbid-elements (#10928) (Thomas BOCQUEZ) - 466c24a linter: Add gitlab reporter output format (#10927) (Connor Pearson) - a064082 linter: Add import/consistent-type-specifier-style rule (#10858) (yefan) - 4733b52 linter/no-extraneous-class: Add conditional fixer (#10798) (DonIsaac) ### Bug Fixes - 87bf2a8 editor: Send only `workspace/didChangeConfiguration` when some workspace configuration is effected (#11017) (Sysix) - ed5708d editor: Detect all workspaces config path changes (#11016) (Sysix) - 89cc21b language_server: Normalize oxlintrc config path (#10982) (Sysix) - c52a9ba linter: Fix plugins inside overrides not being applied (#11057) (camc314) - b12bd48 linter: Fix rule config not being correctly applied (#11055) (camc314) - 9a368be linter: False negative in no-restriced-imports with `patterns` and side effects (#11027) (camc314) - 8c2cfbc linter: False negative in no-restricted-imports (#11026) (camc314) - 8956870 linter: False positive in no-unused-vars (#11002) (camc314) - 33a60d2 linter: Skip eslint/no-redeclare when running on modules (#11004) (camc314) - 39063ce linter: Reword diagnostic message for no-control-regex (#10993) (camc314) - 9eedb58 linter: False positive with negative matches in no-restricted-imports (#10976) (camc314) - 10e77d7 linter: Improve diagnostics for no-control-regex (#10959) (camc314) - 0961296 linter: Add `gitlab` to linter `--help` docs (#10932) (camc314) - 82889ae linter/no-extraneous-class: Improve docs, reporting and code refactor (#10797) (DonIsaac) - 11c34e7 linter/no-img-element: Improve diagnostic and docs (#10908) (DonIsaac) - 584d8b9 napi: Enable mimalloc `no_opt_arch` feature on linux aarch64 (#11053) (Boshen) - 126ae75 semantic: Distinguish class private elements (#11044) (magic-akari) - 773d0de semantic: Correctly handle nested brackets in jsdoc parsing (#10922) (camc314) - b215b6c semantic: Dont parse `@` as jsdoc tags inside `[`/`]` (#10919) (camc314) ### Documentation - db6afb9 linter: Improve docs of no-debugger (#11033) (camc314) - 16541de linter: Improve docs of default-param-last (#11032) (camc314) - 2c2f3c4 linter: Improve docs of default-case-last (#11031) (camc314) - 56bb9ce linter: Improve docs of array-callback-return (#11030) (camc314) - 13dbcc6 linter: Correct docs for default config for no-redeclare (#10995) (camc314) - a86cbb3 linter: Fix incorrect backticks of fenced code blocks (#10947) (Ulrich Stark) ### Refactor - 3cc1466 language_server: New configuration structure for `initialize` and `workspace/didChangeConfiguration` (#10890) (Sysix) - bd2ef7d language_server: Use `Arc` for `diagnostic_report_map` (#10940) (Sysix) - bb999a3 language_server: Avoid cloning linter by taking reference in LintService (#10907) (Ulrich Stark) - d1b0c83 linter: Remove overrides index vec (#11058) (camc314) - 7ad6cf8 linter: Store severity separately, remove `RuleWithSeverity` (#11051) (camchenry) - e31c361 linter: Remove nested match statements in no-restricted-imports (#10975) (camc314) - 6ad9d4f linter: Tidy `eslint/func-names` (#10923) (camc314) - faf0a95 syntax: Rename `NameSpaceModule` to `NamespaceModule` (#10917) (Dunqing) ### Testing - 76b6b33 editor: Add tests for multi workspace folder setup (#10904) (Sysix) Co-authored-by: camc314 <[email protected]>

Now, the editor will not look into `node_modules` folder to use a custom `oxc_language_server`. The editor will always use the provided language server. ## Reasons Because the language server in `node_modules` could be a different version than the extension and changes like #10890 can break the communication between them. Avoiding the JS Wrapper and resolving #9925 and avoiding a new setting #11018 closes #9925 closes #11018

github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 8, 2025

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 92e9c2c to eb5d365 Compare May 8, 2025 12:12

Sysix mentioned this pull request May 8, 2025

feat(language_server/editor): support multi workspace folders #10875

Merged

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch 2 times, most recently from c21ff78 to 2ee56dd Compare May 8, 2025 13:38

Sysix marked this pull request as ready for review May 8, 2025 13:40

Sysix requested a review from camc314 as a code owner May 8, 2025 13:41

graphite-app bot reviewed May 8, 2025

View reviewed changes

crates/oxc_language_server/README.md Outdated Show resolved Hide resolved

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 2ee56dd to c25555b Compare May 8, 2025 13:44

graphite-app bot reviewed May 8, 2025

View reviewed changes

crates/oxc_language_server/README.md Outdated Show resolved Hide resolved

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch 2 times, most recently from f4e6654 to 2e33728 Compare May 8, 2025 17:38

graphite-app bot reviewed May 8, 2025

View reviewed changes

crates/oxc_language_server/src/main.rs Outdated Show resolved Hide resolved

Sysix mentioned this pull request May 8, 2025

test(editor): add tests for multi workspace folder setup #10904

Merged

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 2e33728 to a234590 Compare May 8, 2025 18:30

camc314 approved these changes May 9, 2025

View reviewed changes

Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from a234590 to d6a63d2 Compare May 9, 2025 10:24

Sysix mentioned this pull request May 10, 2025

feat(language_server): better fallback handling when passing invalid Options values #10930

Merged

nrayburn-tech mentioned this pull request May 11, 2025

Migrate to new initialize config format oxc-project/oxc-intellij-plugin#185

Closed

Sysix added the 0-merge Merge with Graphite Merge Queue label May 11, 2025

graphite-app bot force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from d6a63d2 to 3cc1466 Compare May 11, 2025 14:31

graphite-app bot merged commit 3cc1466 into main May 11, 2025
28 checks passed

graphite-app bot deleted the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch May 11, 2025 14:34

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 11, 2025

oxc-bot mentioned this pull request May 16, 2025

release(oxlint): v0.16.11 #11066

Merged

Sysix mentioned this pull request May 18, 2025

refactor(editor): use always the provided language server #11115

Merged

Sysix mentioned this pull request Jun 9, 2025

refactor(language_server)!: remove support for old configuration objects in initialize and workspace/didChangeConfiguration #11578

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` #10890

refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` #10890

Uh oh!

Sysix commented May 8, 2025 •

edited

Loading

Uh oh!

Sysix commented May 8, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Sysix commented May 8, 2025

Uh oh!

Uh oh!

Uh oh!

nrayburn-tech commented May 9, 2025

Uh oh!

Sysix commented May 11, 2025

Uh oh!

Sysix commented May 11, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

refactor(language_server): new configuration structure for initialize and workspace/didChangeConfiguration #10890

refactor(language_server): new configuration structure for initialize and workspace/didChangeConfiguration #10890

Uh oh!

Conversation

Sysix commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10890 will not alter performance

Summary

Uh oh!

Uh oh!

Sysix commented May 8, 2025

Uh oh!

Uh oh!

Uh oh!

nrayburn-tech commented May 9, 2025

Uh oh!

Sysix commented May 11, 2025

Uh oh!

Sysix commented May 11, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` #10890

refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` #10890

Sysix commented May 8, 2025 •

edited

Loading

Sysix commented May 8, 2025 •

edited

Loading

codspeed-hq bot commented May 8, 2025 •

edited

Loading

Sysix commented May 11, 2025 •

edited by graphite-app bot

Loading