-
-
Notifications
You must be signed in to change notification settings - Fork 781
fix(linter): delay merging of oxlintrc configs #10835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): delay merging of oxlintrc configs #10835
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10835 will not alter performanceComparing Summary
|
72ce533 to
7b7270e
Compare
7b7270e to
fcee2d4
Compare
efbe119 to
8716f4c
Compare
5ec242f to
adb9b1f
Compare
328d273 to
16cdcff
Compare
e483940 to
7591333
Compare
16cdcff to
73ebe3c
Compare
f9c2ed2 to
f8de424
Compare
5993a4f to
3abd4d1
Compare
f8de424 to
033a278
Compare
3abd4d1 to
577be95
Compare
f1e71af to
e832938
Compare
577be95 to
9bf7d03
Compare
e832938 to
e52b015
Compare
9bf7d03 to
9b51c7d
Compare
287a9ea to
524cad3
Compare
Sysix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test it, only looked into the code. :)
46c7669 to
7057edc
Compare
7057edc to
c47cd3e
Compare
c47cd3e to
24d8d5b
Compare
eec266d to
c52a9ba
Compare
24d8d5b to
59503ed
Compare
59503ed to
61a3adb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just caught up on this issue, and I think deferring the rule merging makes sense, as long as the perf hit isn't too bad (if any). Have we done any local testing on this?
|
been testin this on the esisting integration tests, i've also got a couple of configs locally I've been testing this on. |
61a3adb to
43e6f40
Compare
|
Can we merge this :)? |
Merge activity
|
|
yep i meant to add the tag earlier but must not have pressed the button |
43e6f40 to
e8470d9
Compare

fixes #10760