Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented May 6, 2025

fixes #10760

Copy link
Contributor Author

camc314 commented May 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Instrumentation Performance Report

Merging #10835 will not alter performance

Comparing c/05-06-fix_linter_delay_merging_of_oxlintrc_configs (e8470d9) with main (cef5452)

Summary

✅ 38 untouched benchmarks

@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 72ce533 to 7b7270e Compare May 7, 2025 08:47
@camc314 camc314 changed the base branch from main to graphite-base/10835 May 7, 2025 13:11
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 7b7270e to fcee2d4 Compare May 7, 2025 13:11
@camc314 camc314 changed the base branch from graphite-base/10835 to c/05-07-refactor_linter_move_around_some_config_store_logic May 7, 2025 13:11
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch 3 times, most recently from efbe119 to 8716f4c Compare May 7, 2025 14:23
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch from 5ec242f to adb9b1f Compare May 7, 2025 15:20
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch 2 times, most recently from 328d273 to 16cdcff Compare May 7, 2025 15:26
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch from e483940 to 7591333 Compare May 7, 2025 15:26
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 16cdcff to 73ebe3c Compare May 8, 2025 09:46
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch 2 times, most recently from f9c2ed2 to f8de424 Compare May 8, 2025 09:51
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch 2 times, most recently from 5993a4f to 3abd4d1 Compare May 8, 2025 10:00
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch from f8de424 to 033a278 Compare May 8, 2025 10:00
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 3abd4d1 to 577be95 Compare May 8, 2025 10:21
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch 2 times, most recently from f1e71af to e832938 Compare May 8, 2025 10:57
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 577be95 to 9bf7d03 Compare May 8, 2025 10:57
@camc314 camc314 force-pushed the c/05-07-refactor_linter_move_around_some_config_store_logic branch from e832938 to e52b015 Compare May 8, 2025 11:14
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 9bf7d03 to 9b51c7d Compare May 8, 2025 11:14
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 287a9ea to 524cad3 Compare May 9, 2025 14:05
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it, only looked into the code. :)

@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch 2 times, most recently from 46c7669 to 7057edc Compare May 15, 2025 12:14
@camc314 camc314 changed the base branch from main to graphite-base/10835 May 15, 2025 12:26
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 7057edc to c47cd3e Compare May 15, 2025 12:26
@camc314 camc314 changed the base branch from graphite-base/10835 to c/05-15-fix_linter_fix_plugins_inside_overrides_not_being_applied May 15, 2025 12:26
@graphite-app graphite-app bot changed the base branch from c/05-15-fix_linter_fix_plugins_inside_overrides_not_being_applied to graphite-base/10835 May 15, 2025 12:31
@graphite-app graphite-app bot force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from c47cd3e to 24d8d5b Compare May 15, 2025 12:38
@graphite-app graphite-app bot force-pushed the graphite-base/10835 branch from eec266d to c52a9ba Compare May 15, 2025 12:38
@graphite-app graphite-app bot changed the base branch from graphite-base/10835 to main May 15, 2025 12:39
@graphite-app graphite-app bot force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 24d8d5b to 59503ed Compare May 15, 2025 12:39
@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 59503ed to 61a3adb Compare May 18, 2025 23:25
Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just caught up on this issue, and I think deferring the rule merging makes sense, as long as the perf hit isn't too bad (if any). Have we done any local testing on this?

@camc314
Copy link
Contributor Author

camc314 commented May 21, 2025

been testin this on the esisting integration tests, i've also got a couple of configs locally I've been testing this on.

@camc314 camc314 force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 61a3adb to 43e6f40 Compare May 21, 2025 15:21
@Sysix
Copy link
Member

Sysix commented May 21, 2025

Can we merge this :)?
#10373 is waiting for it.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 21, 2025
Copy link
Contributor Author

camc314 commented May 21, 2025

Merge activity

@camc314
Copy link
Contributor Author

camc314 commented May 21, 2025

yep i meant to add the tag earlier but must not have pressed the button

@graphite-app graphite-app bot force-pushed the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch from 43e6f40 to e8470d9 Compare May 21, 2025 17:18
@graphite-app graphite-app bot merged commit e8470d9 into main May 21, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/05-06-fix_linter_delay_merging_of_oxlintrc_configs branch May 21, 2025 17:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: oxlint does the follow the complete extends chain.

4 participants