Skip to content

refactor(language_server): use IsolatedLintHandlerFileSystem #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 6, 2025
Merged

refactor(language_server): use IsolatedLintHandlerFileSystem #10830

graphite-app merged 1 commit into from
May 6, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 6, 2025

No description provided.

@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented May 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10830 will create unknown performance changes

Comparing 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ (3d47159) with main (47b946d)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.2 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 714.5 ms N/A
🆕 formatter[react.development.js] N/A 8.1 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[checker.ts] N/A 14.4 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.9 µs N/A
🆕 mangler[typescript.js] N/A 39.6 ms N/A
🆕 minifier[antd.js] N/A 164.3 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 288.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Sysix Sysix marked this pull request as ready for review May 6, 2025 12:39
@Sysix Sysix force-pushed the 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ branch from 0cf7dde to c70b527 Compare May 6, 2025 12:42
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from a3124b3 to 58a594b Compare May 6, 2025 12:42
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 58a594b to 481af64 Compare May 6, 2025 13:10
@Sysix Sysix force-pushed the 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ branch from c70b527 to 7d90971 Compare May 6, 2025 13:10
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented May 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

@Sysix Sysix force-pushed the 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ branch from 7d90971 to 84f6125 Compare May 6, 2025 14:46
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 481af64 to 522c37c Compare May 6, 2025 14:46
@graphite-app graphite-app bot force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 522c37c to 47b946d Compare May 6, 2025 15:00
@graphite-app graphite-app bot force-pushed the 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ branch from 84f6125 to 3d47159 Compare May 6, 2025 15:01
Base automatically changed from 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem to main May 6, 2025 15:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@graphite-app graphite-app bot merged commit 3d47159 into main May 6, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 05-06-refactor_language_server_use_isolatedlinthandlerfilesystem_ branch May 6, 2025 15:05
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314