Skip to content

test(linter): use TesterFileSystem for Runtimes filesystem #10829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 6, 2025
Merged

test(linter): use TesterFileSystem for Runtimes filesystem #10829

graphite-app merged 1 commit into from
May 6, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 6, 2025

No description provided.

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10829 will not alter performance

Comparing 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem (47b946d) with main (243c247)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 955b139 to 784fd0d Compare May 6, 2025 12:29
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from db37d58 to a3124b3 Compare May 6, 2025 12:29
@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@Sysix Sysix marked this pull request as ready for review May 6, 2025 12:39
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from a3124b3 to 58a594b Compare May 6, 2025 12:42
@Sysix Sysix force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 784fd0d to 5600f91 Compare May 6, 2025 12:42
camc314
camc314 reviewed May 6, 2025
View reviewed changes
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 58a594b to 481af64 Compare May 6, 2025 13:10
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented May 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime to graphite-base/10829 May 6, 2025 13:50
@Sysix Sysix force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 481af64 to 522c37c Compare May 6, 2025 14:46
@Sysix Sysix changed the base branch from graphite-base/10829 to 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime May 6, 2025 14:46
@Sysix Sysix force-pushed the graphite-base/10829 branch from 5600f91 to 243c247 Compare May 6, 2025 14:46
Base automatically changed from 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime to main May 6, 2025 14:54
@graphite-app graphite-app bot force-pushed the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch from 522c37c to 47b946d Compare May 6, 2025 15:00
@graphite-app graphite-app bot merged commit 47b946d into main May 6, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-06-test_linter_use_testerfilesystem_for_runtime_s_filesystem branch May 6, 2025 15:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314