Skip to content

refactor(linter): able to use custom file system in runtime #10828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 6, 2025
Merged

refactor(linter): able to use custom file system in runtime #10828

graphite-app merged 1 commit into from
May 6, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 6, 2025 •
edited
Loading

The goal of this Stack is to remove the Runtime properties behind a feature/test flag

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10828 will not alter performance

Comparing 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime (243c247) with main (ae70cc1)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 955b139 to 784fd0d Compare May 6, 2025 12:29
@Sysix Sysix mentioned this pull request May 6, 2025
Merged
@Sysix Sysix marked this pull request as ready for review May 6, 2025 12:39
graphite-app[bot]
graphite-app bot reviewed May 6, 2025
View reviewed changes
@Sysix Sysix force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 784fd0d to 5600f91 Compare May 6, 2025 12:42
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented May 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • May 6, 8:47 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 6, 8:47 AM EDT: camc314 added this pull request to the Graphite merge queue.
  • May 6, 8:47 AM EDT: CI is running for this pull request on a draft pull request (#10831) due to your merge queue CI optimization settings.
  • May 6, 12:48 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (Label and Check PR Title)).
  • May 6, 9:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 6, 9:33 AM EDT: Sysix added this pull request to the Graphite merge queue.
  • May 6, 9:33 AM EDT: CI is running for this pull request on a draft pull request (#10832) due to your merge queue CI optimization settings.
  • May 6, 1:35 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (Label and Check PR Title)).
  • May 6, 9:49 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 6, 9:49 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 6, 2:21 PM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
  • May 6, 10:53 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 6, 10:53 AM EDT: Sysix added this pull request to the Graphite merge queue.
  • May 6, 10:54 AM EDT: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request May 6, 2025
@Sysix
refactor(linter): able to use custom file system in runtime (#10828)
b65d4d8 
The goal of this Stack is to remove the Runtime properties behind a feature/test flag
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
graphite-app bot pushed a commit that referenced this pull request May 6, 2025
@Sysix
refactor(linter): able to use custom file system in runtime (#10828)
4e3a327 
The goal of this Stack is to remove the Runtime properties behind a feature/test flag
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
graphite-app bot pushed a commit that referenced this pull request May 6, 2025
@Sysix
refactor(linter): able to use custom file system in runtime (#10828)
9bf6855 
The goal of this Stack is to remove the Runtime properties behind a feature/test flag
@graphite-app graphite-app bot force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 5600f91 to 9bf6855 Compare May 6, 2025 13:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@Sysix
refactor(linter): able to use custom file system in runtime (#10828)
243c247 
The goal of this Stack is to remove the Runtime properties behind a feature/test flag
@Sysix Sysix force-pushed the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch from 9bf6855 to 243c247 Compare May 6, 2025 14:46
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@graphite-app graphite-app bot merged commit 243c247 into main May 6, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 05-06-refactor_linter_able_to_use_custom_file_system_in_runtime branch May 6, 2025 14:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sysix @camc314 @Boshen