fix(linter/no-unused-vars): fixer cannot delete usused for in/of iterators #10824
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10824 will not alter performanceComparing Summary
|
DonIsaac
force-pushed
the
don/05-05-fix_linter/no-unused-vars_fixer_cannot_delete_usused_for_in/of_iterators
branch
from
389c523 to
b434fd0
Compare
camc314
approved these changes
May 6, 2025
Contributor
Merge activity
|
…ators (#10824) Previously, `no-unused-vars` would fix ```js for (const foo of thing) {} ``` into ```js for ( of thing) {} ``` which is obviously wrong. Now it tries to rename it to an allowed unused pattern, or returns a noop if not.
graphite-app
bot
force-pushed
the
don/05-05-fix_linter/no-unused-vars_fixer_cannot_delete_usused_for_in/of_iterators
branch
from
f20a14a to
b2c287f
Compare
graphite-app
bot
deleted the
don/05-05-fix_linter/no-unused-vars_fixer_cannot_delete_usused_for_in/of_iterators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
no-unused-varswould fixinto
which is obviously wrong.
Now it tries to rename it to an allowed unused pattern, or returns a noop if not.