Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 5, 2025

Related oxc-project/oxc-intellij-plugin#177

When the client request code actions or commands for a file. This file must not be open to be requested.
In the main, we are just looking into our diagnostics_map, which will be filled only on open/change/close of the text document.

When the client request now a code action or command for a file, we will lint them only (if not already done) and avoid filling the diagnostic_map.

Copy link
Member Author

Sysix commented May 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels May 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 5, 2025

CodSpeed Instrumentation Performance Report

Merging #10815 will not alter performance

Comparing 05-05-feat_language_server_provide_commands___code_actions_without_opening_files (3bd339b) with main (b2c287f)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-05-feat_language_server_provide_commands___code_actions_without_opening_files branch from 875fafa to 44ef6f9 Compare May 5, 2025 14:37
@Sysix Sysix marked this pull request as ready for review May 5, 2025 16:05
@Sysix Sysix changed the title feat(language_server): provide commands / code actions without opening files feat(language_server): provide commands / code actions for unopened files May 5, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 6, 2025
Copy link
Contributor

camc314 commented May 6, 2025

Merge activity

…iles (#10815)

Related oxc-project/oxc-intellij-plugin#177

When the client request code actions or commands for a file. This file must not be open to be requested.
In the main, we are just looking into our `diagnostics_map`, which will be filled only on open/change/close of the text document.

When the client request now a code action or command for a file, we will lint them only (if not already done) and avoid filling the `diagnostic_map`.
@graphite-app graphite-app bot force-pushed the 05-05-feat_language_server_provide_commands___code_actions_without_opening_files branch from 44ef6f9 to 3bd339b Compare May 6, 2025 08:38
@graphite-app graphite-app bot merged commit 3bd339b into main May 6, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 6, 2025
@graphite-app graphite-app bot deleted the 05-05-feat_language_server_provide_commands___code_actions_without_opening_files branch May 6, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants