Skip to content

perf(language_server): use simdutf8 when reading files from file system #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 5, 2025
Merged

perf(language_server): use simdutf8 when reading files from file system #10814

graphite-app merged 1 commit into from
May 5, 2025
+8 −3

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 5, 2025

No description provided.

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance labels May 5, 2025
@Sysix Sysix marked this pull request as ready for review May 5, 2025 12:44
graphite-app[bot]
graphite-app bot reviewed May 5, 2025
View reviewed changes
@coderabbitai
Copy link

coderabbitai bot commented May 5, 2025 •
edited
Loading

Walkthrough

The changes introduce a new utility function, read_to_string, within the utils module of the oxc_linter crate. This function reads file contents as raw bytes, validates them as UTF-8 using the simdutf8 crate for improved performance, and returns the contents as a String. If the content is not valid UTF-8, it returns an error consistent with the standard library's behavior. This function is now publicly re-exported from the crate root, making it accessible to users of the crate. In the oxc_language_server crate, usage of the standard library's fs::read_to_string has been replaced with the newly introduced read_to_string function from oxc_linter::loader in the IsolatedLintHandler's lint_path method. The rest of the logic and error handling remains unchanged. No changes were made to the declarations of other exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4c50b1 and 96cca22.

📒 Files selected for processing (3)
  • crates/oxc_language_server/src/linter/isolated_lint_handler.rs (2 hunks)
  • crates/oxc_linter/src/lib.rs (1 hunks)
  • crates/oxc_linter/src/utils/mod.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • crates/oxc_language_server/src/linter/isolated_lint_handler.rs
  • crates/oxc_linter/src/lib.rs
  • crates/oxc_linter/src/utils/mod.rs
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Test wasm32-wasip1-threads
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Test Linux
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Test VSCode
  • GitHub Check: Clippy
  • GitHub Check: Build Linter Benchmark
  • GitHub Check: Benchmark (lexer)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Sysix Sysix force-pushed the 05-05-perf_language_server_use_simdutf8_when_reading_files_from_file_system branch from e577132 to d4c50b1 Compare May 5, 2025 12:49
@codspeed-hq
Copy link

codspeed-hq bot commented May 5, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10814 will not alter performance

Comparing 05-05-perf_language_server_use_simdutf8_when_reading_files_from_file_system (96cca22) with main (5ce0a68)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 5, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented May 5, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 05-05-perf_language_server_use_simdutf8_when_reading_files_from_file_system branch from d4c50b1 to 96cca22 Compare May 5, 2025 14:40
@graphite-app graphite-app bot merged commit 96cca22 into main May 5, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-05-perf_language_server_use_simdutf8_when_reading_files_from_file_system branch May 5, 2025 14:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 5, 2025
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sysix @Boshen @camc314