Skip to content

fix(language_server): return server version initialize response #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 5, 2025
Merged

fix(language_server): return server version initialize response #10810

graphite-app merged 1 commit into from
May 5, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 5, 2025 •
edited
Loading

closes #10799

2025-05-05 12:38:19.243 [info] [Trace - 12:38:19 PM] Received response 'initialize - (0)' in 331ms.
2025-05-05 12:38:19.243 [info] Result: {
    "capabilities": {
        "textDocumentSync": 1,
        "codeActionProvider": {
            "codeActionKinds": [
                "quickfix",
                "source.fixAll.oxc"
            ]
        },
        "executeCommandProvider": {
            "commands": [
                "oxc.fixAll"
            ]
        },
        "workspace": {
            "workspaceFolders": {
                "supported": true,
                "changeNotifications": true
            }
        }
    },
    "serverInfo": {
        "name": "oxc",
        "version": "0.16.9"
    }
}

@Sysix Graphite App
Copy link
Member Author

Sysix commented May 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels May 5, 2025
@Sysix Sysix marked this pull request as ready for review May 5, 2025 10:41
@coderabbitai
Copy link

coderabbitai bot commented May 5, 2025 •
edited
Loading

Walkthrough

The initialize method within the LanguageServer implementation for the Backend struct was updated to introduce a local variable, server_version, which captures the server version string from the compile-time environment variable CARGO_PKG_VERSION. This variable is now used both for logging the language server version and for populating the version field of the ServerInfo struct in the InitializeResult response. Previously, the version was logged directly using the macro and the version field in ServerInfo was set to None. With this change, the server version is consistently reported in logs and explicitly included in the initialization response. There were no changes to the signatures of any exported or public entities; all modifications are internal to the initialize method.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc2aad and 24fcb1e.

📒 Files selected for processing (1)
  • crates/oxc_language_server/src/main.rs (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/oxc_language_server/src/main.rs
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Test wasm32-wasip1-threads
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Test Linux
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Benchmark (lexer)
  • GitHub Check: Test VSCode
  • GitHub Check: Clippy
  • GitHub Check: Build Linter Benchmark
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codspeed-hq
Copy link

codspeed-hq bot commented May 5, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10810 will not alter performance

Comparing 05-05-fix_language_server_return_server_version_initialize_response (24fcb1e) with main (96cca22)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-05-fix_language_server_return_server_version_initialize_response branch from dd8a82d to 4dc2aad Compare May 5, 2025 10:55
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label May 5, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented May 5, 2025 •
edited by graphite-app bot
Loading

Merge activity

@Sysix
fix(language_server): return server version initialize response (#1…
24fcb1e 
…0810)

closes #10799

```
2025-05-05 12:38:19.243 [info] [Trace - 12:38:19 PM] Received response 'initialize - (0)' in 331ms.
2025-05-05 12:38:19.243 [info] Result: {
    "capabilities": {
        "textDocumentSync": 1,
        "codeActionProvider": {
            "codeActionKinds": [
                "quickfix",
                "source.fixAll.oxc"
            ]
        },
        "executeCommandProvider": {
            "commands": [
                "oxc.fixAll"
            ]
        },
        "workspace": {
            "workspaceFolders": {
                "supported": true,
                "changeNotifications": true
            }
        }
    },
    "serverInfo": {
        "name": "oxc",
        "version": "0.16.9"
    }
}
```
@graphite-app graphite-app bot force-pushed the 05-05-fix_language_server_return_server_version_initialize_response branch from 4dc2aad to 24fcb1e Compare May 5, 2025 14:44
@graphite-app graphite-app bot merged commit 24fcb1e into main May 5, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 05-05-fix_language_server_return_server_version_initialize_response branch May 5, 2025 14:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 5, 2025
@Sysix Sysix mentioned this pull request May 5, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

language_server: Report version in InitializeResult

3 participants

@Sysix @camc314