Skip to content

fix(linter/no-unused-vars): Recognize parameters used in await/yield expressions within comma expressions #10808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camchenry merged 3 commits into from
May 5, 2025
Merged

fix(linter/no-unused-vars): Recognize parameters used in await/yield expressions within comma expressions #10808

camchenry merged 3 commits into from
May 5, 2025

Conversation

@magic-akari
Copy link
Contributor

@magic-akari magic-akari commented May 5, 2025

@graphite-app
Copy link
Contributor

graphite-app bot commented May 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels May 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 5, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10808 will not alter performance

Comparing magic-akari:fix/issue-10806 (18e3ac6) with main (62c3a4a)

Summary

✅ 36 untouched benchmarks

@magic-akari magic-akari marked this pull request as ready for review May 5, 2025 07:27
@magic-akari magic-akari changed the title fix(no_unused_vars): Recognize parameters used in await/yield expressions within comma expressions fix(linter/no-unused-vars): Recognize parameters used in await/yield expressions within comma expressions May 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 5, 2025 •
edited
Loading

Walkthrough

The changes update the no_unused_vars lint rule in the linter. The is_discarded_read method in the Symbol implementation is modified to treat references inside AwaitExpression and YieldExpression nodes within a SequenceExpression similarly to those inside CallExpression nodes, so these are not considered discarded reads. Additionally, two new passing test cases are added to the no_unused_vars rule tests. These tests cover exported functions returning either an async arrow function or a generator function that invoke a passed-in asynchronous function and then return a value. No changes are made to the signatures or declarations of any exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73c8896 and 18e3ac6.

📒 Files selected for processing (1)
  • crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Test Linux
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Build Linter Benchmark
  • GitHub Check: Clippy
  • GitHub Check: Benchmark (lexer)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Dunqing
Dunqing previously requested changes May 5, 2025
View reviewed changes
@Dunqing Dunqing requested a review from camc314 May 5, 2025 11:59
@camchenry camchenry merged commit 5ce0a68 into oxc-project:main May 5, 2025
26 checks passed
@oxc-bot oxc-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

@camc314 camc314 camc314 approved these changes

@Dunqing Dunqing Dunqing left review comments

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: no-unused-vars ignores the use of await usage before the comma operator

4 participants

@magic-akari @camchenry @camc314 @Dunqing