refactor(language_server): move nested_configs to ServerLinter
#10775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
CodSpeed Instrumentation Performance ReportMerging #10775 will not alter performanceComparing Summary
|
graphite-app
bot
force-pushed
the
05-02-refactor_language_server_move_gitignore_glob_to_serverlinter_
branch
2 times, most recently
from
5087608 to
8c611a6
Compare
graphite-app
bot
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
899c673 to
40f6402
Compare
Sysix
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
40f6402 to
141d7e2
Compare
Sysix
force-pushed
the
05-02-refactor_language_server_move_gitignore_glob_to_serverlinter_
branch
from
8c611a6 to
88072e4
Compare
Sysix
force-pushed
the
05-02-refactor_language_server_move_gitignore_glob_to_serverlinter_
branch
from
88072e4 to
fb5a464
Compare
Sysix
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
141d7e2 to
70ab58d
Compare
graphite-app
bot
changed the base branch from
05-02-refactor_language_server_move_gitignore_glob_to_serverlinter_
to
graphite-base/10775
graphite-app
bot
force-pushed
the
graphite-base/10775
branch
from
fb5a464 to
9ec13f6
Compare
graphite-app
bot
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
70ab58d to
851a12e
Compare
graphite-app
bot
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
851a12e to
12f7863
Compare
camc314
reviewed
May 7, 2025
camc314
approved these changes
May 7, 2025
Sysix
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
12f7863 to
bb1a31e
Compare
Member
Author
Merge activity
|
…10775) Normally we would just restart the `ServerLinter.isolated_linter` or the `Worker.nested_configs`. I do not see the benefits to store the `nested_configs` separately and changing them + the `isolated_linter` when needed. And I do not want to change `isolated_linter` from `Arc` to `RwLock` / `Mutex`. When a `.oxlintrc.json` file changes, we just set up the linter and searching for all nested configs again.
graphite-app
bot
force-pushed
the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
from
bb1a31e to
39e0463
Compare
graphite-app
bot
deleted the
05-03-refactor_language_server_move_nested_configs_to_serverlinter_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we would just restart the
ServerLinter.isolated_linteror theWorker.nested_configs.I do not see the benefits to store the
nested_configsseparately and changing them + theisolated_linterwhen needed.And I do not want to change
isolated_linterfromArctoRwLock/Mutex.When a
.oxlintrc.jsonfile changes, we just set up the linter and searching for all nested configs again.