fix(linter): make require post message target origin a fixer a suggestion #10754

camc314 · 2025-05-01T12:49:58Z

previously, the below fixer fixed the code

export function getPostMessage(port: MessagePort): <T>(message: T) => void {
-  return <T>(message: T) => port.postMessage(message);
+  return <T>(message: T) => port.postMessage(message, port.location.origin);
}

which is unsafe since MessagePort does not have that type signature.

camc314 · 2025-05-01T12:50:15Z

fix(linter): make require post message target origin a fixer a suggestion #10754 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-05-01T12:52:11Z

Walkthrough

The changes modify the lint rule RequirePostMessageTargetOrigin in the crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs file. Specifically, the lint’s declaration was updated to categorize it as a "suggestion" rather than a "fix". This is reflected in the macro invocation for the lint, changing its kind from fix to suggestion. Additionally, the code for emitting diagnostics was updated from using ctx.diagnostic_with_fix to ctx.diagnostic_with_suggestion. No other logic, control flow, or functionality was altered in this update.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5afab9 and b38338a.

📒 Files selected for processing (1)

crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs

⏰ Context from checks skipped due to timeout of 90000ms (12)

GitHub Check: Benchmark (codegen)
GitHub Check: Benchmark (formatter)
GitHub Check: Benchmark (transformer)
GitHub Check: Clippy
GitHub Check: Benchmark (isolated_declarations)
GitHub Check: Benchmark (semantic)
GitHub Check: Benchmark (parser)
GitHub Check: Benchmark (minifier)
GitHub Check: Benchmark (lexer)
GitHub Check: Test (ubuntu-latest)
GitHub Check: Test (macos-latest)
GitHub Check: Build Linter Benchmark

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-05-01T12:56:50Z

CodSpeed Instrumentation Performance Report

Merging #10754 will not alter performance

_{Comparing c/05-01-fix_linter_make_require_post_message_target_origin_a_fixer_a_suggestion (b38338a) with main (050ecd9)}

Summary

✅ 36 untouched benchmarks

camc314 · 2025-05-01T13:13:35Z

Merge activity

May 1, 9:13 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

graphite-app · 2025-05-01T13:13:36Z

Merge activity

May 1, 9:13 AM EDT: camc314 added this pull request to the Graphite merge queue.
May 1, 9:16 AM EDT: Merged by the Graphite merge queue.

…tion (#10754) from #10439 previously, the below fixer fixed the code ``` export function getPostMessage(port: MessagePort): <T>(message: T) => void { - return <T>(message: T) => port.postMessage(message); + return <T>(message: T) => port.postMessage(message, port.location.origin); } ``` which is unsafe since `MessagePort` does not have that type signature.

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels May 1, 2025

camc314 marked this pull request as ready for review May 1, 2025 12:50

camc314 added the 0-merge Merge with Graphite Merge Queue label May 1, 2025

graphite-app bot force-pushed the c/05-01-fix_linter_make_require_post_message_target_origin_a_fixer_a_suggestion branch from f5afab9 to b38338a Compare May 1, 2025 13:14

graphite-app bot merged commit b38338a into main May 1, 2025
23 checks passed

graphite-app bot deleted the c/05-01-fix_linter_make_require_post_message_target_origin_a_fixer_a_suggestion branch May 1, 2025 13:17

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 1, 2025

oxc-bot mentioned this pull request May 2, 2025

release(oxlint): v0.16.9 #10765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter): make require post message target origin a fixer a suggestion #10754

fix(linter): make require post message target origin a fixer a suggestion #10754

Uh oh!

camc314 commented May 1, 2025 •

edited

Loading

Uh oh!

camc314 commented May 1, 2025

Uh oh!

coderabbitai bot commented May 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codspeed-hq bot commented May 1, 2025 •

edited

Loading

Uh oh!

camc314 commented May 1, 2025

Uh oh!

graphite-app bot commented May 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(linter): make require post message target origin a fixer a suggestion #10754

fix(linter): make require post message target origin a fixer a suggestion #10754

Uh oh!

Conversation

camc314 commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented May 1, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codspeed-hq bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10754 will not alter performance

Summary

Uh oh!

camc314 commented May 1, 2025

Merge activity

Uh oh!

graphite-app bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented May 1, 2025 •

edited

Loading

coderabbitai bot commented May 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codspeed-hq bot commented May 1, 2025 •

edited

Loading

graphite-app bot commented May 1, 2025 •

edited

Loading