Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented May 1, 2025

fixes #10540

Copy link
Contributor Author

camc314 commented May 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels May 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10742 will not alter performance

Comparing c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files (98bcd5f) with main (60347e7)

Summary

✅ 36 untouched benchmarks

@camc314 camc314 changed the base branch from c/05-01-chore_lsp_derive_debug_for_some_more_structs to graphite-base/10742 May 1, 2025 09:22
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 4d4fd21 to 107e906 Compare May 1, 2025 09:22
@camc314 camc314 changed the base branch from graphite-base/10742 to c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots May 1, 2025 09:22
@camc314 camc314 marked this pull request as ready for review May 1, 2025 09:23
@camc314 camc314 force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from 3649fc1 to f2a6b0e Compare May 1, 2025 09:25
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch 2 times, most recently from 33af39a to 2f87879 Compare May 1, 2025 09:27
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label May 1, 2025
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 2f87879 to fa7f970 Compare May 1, 2025 09:35
@camc314 camc314 requested a review from Sysix May 1, 2025 09:36
@camc314 camc314 force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from f2a6b0e to 5809b00 Compare May 1, 2025 09:46
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from fa7f970 to 723de34 Compare May 1, 2025 09:46
@camc314 camc314 force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from 5809b00 to f7e2491 Compare May 1, 2025 09:49
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 723de34 to e5b199f Compare May 1, 2025 09:49
@graphite-app graphite-app bot force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch 2 times, most recently from 04aa661 to 062a2b0 Compare May 1, 2025 10:03
@graphite-app graphite-app bot force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from e5b199f to b0c903e Compare May 1, 2025 10:03
@camc314 camc314 changed the base branch from c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots to graphite-base/10742 May 1, 2025 10:30
@camc314 camc314 force-pushed the graphite-base/10742 branch from 062a2b0 to 20aeedf Compare May 1, 2025 10:30
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from b0c903e to 166a867 Compare May 1, 2025 10:30
@camc314 camc314 changed the base branch from graphite-base/10742 to c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots May 1, 2025 10:31
@camc314 camc314 changed the base branch from c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots to graphite-base/10742 May 1, 2025 10:32
@camc314 camc314 force-pushed the graphite-base/10742 branch from 20aeedf to 3067972 Compare May 1, 2025 10:32
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 166a867 to 6b00f3c Compare May 1, 2025 10:32
@camc314 camc314 changed the base branch from graphite-base/10742 to c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots May 1, 2025 10:32
@camc314 camc314 force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from 3067972 to 36b66b9 Compare May 1, 2025 10:37
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 6b00f3c to 21c49c1 Compare May 1, 2025 10:37
@camc314 camc314 changed the base branch from c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots to graphite-base/10742 May 1, 2025 10:38
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from 21c49c1 to d052f10 Compare May 1, 2025 10:38
@camc314 camc314 force-pushed the graphite-base/10742 branch from 36b66b9 to fd882a6 Compare May 1, 2025 10:38
@camc314 camc314 changed the base branch from graphite-base/10742 to c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots May 1, 2025 10:38
@camc314 camc314 force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from d052f10 to a108eca Compare May 1, 2025 11:00
@camc314 camc314 changed the title fix(lsp): inccorrect quick fix offset in vue files fix(lsp): incorrect quick fix offset in vue files May 1, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 1, 2025
Copy link
Member

Boshen commented May 1, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from fd882a6 to 4ac58ea Compare May 1, 2025 13:55
graphite-app bot pushed a commit that referenced this pull request May 1, 2025
@graphite-app graphite-app bot force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from a108eca to dbc8d73 Compare May 1, 2025 13:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 1, 2025
@camc314 camc314 added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels May 1, 2025
@graphite-app graphite-app bot force-pushed the c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots branch from 4ac58ea to f6f1c5c Compare May 1, 2025 14:41
@graphite-app graphite-app bot force-pushed the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch from dbc8d73 to 98bcd5f Compare May 1, 2025 14:42
Base automatically changed from c/05-01-tests_lsp_include_fixed_content_in_lsp_snapshots to main May 1, 2025 14:47
@graphite-app graphite-app bot merged commit 98bcd5f into main May 1, 2025
28 of 29 checks passed
@graphite-app graphite-app bot deleted the c/05-01-fix_lsp_inccorrect_quick_fix_offset_in_vue_files branch May 1, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: lsp fixers do not have the correct offset in .vue files

3 participants