fix(linter): fix false positive in react/exhaustive deps #10727

camc314 · 2025-04-30T14:04:50Z

Fix React exhaustive-deps rule to correctly handle useCallback references

This PR fixes the exhaustive-deps rule to no longer consider useCallback as a stable value, which was causing incorrect linting behavior. The change:

Removes useCallback from the stable value check, as it should not be treated like useRef
Updates tests to reflect this change by:
- Commenting out tests that would cause infinite loops at runtime
- Uncommenting a test case that should now pass
- Adding a test case for the specific issue reported in linter: react/exhaustive-deps false negative #9788

closes #9788

camc314 · 2025-04-30T14:05:06Z

fix(linter): fix false positive in react/exhaustive deps #10727 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-04-30T14:10:15Z

Walkthrough

The changes update the React hooks linter by removing "useCallback" from the set of hooks considered stable in the is_stable_value function, leaving only "useRef" as stable. Correspondingly, two test cases involving recursive useCallback calls that lead to infinite loops are commented out with explanations that these scenarios are unsupported. A previously disabled test involving nested useCallback references is enabled. Additionally, a new test case related to GitHub issue #9788 is added, which tests a component using useCallback and useEffect where the callback is invoked inside an effect with an empty dependency array. No changes were made to exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a7067db and c9575f6.

⛔ Files ignored due to path filters (1)

crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

crates/oxc_linter/src/rules/react/exhaustive_deps.rs (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

crates/oxc_linter/src/rules/react/exhaustive_deps.rs

⏰ Context from checks skipped due to timeout of 90000ms (13)

GitHub Check: Doc
GitHub Check: Clippy
GitHub Check: Test (ubuntu-latest)
GitHub Check: Test (macos-latest)
GitHub Check: Benchmark (codegen)
GitHub Check: Benchmark (semantic)
GitHub Check: Benchmark (minifier)
GitHub Check: Benchmark (formatter)
GitHub Check: Benchmark (isolated_declarations)
GitHub Check: Benchmark (lexer)
GitHub Check: Benchmark (transformer)
GitHub Check: Benchmark (parser)
GitHub Check: Build Linter Benchmark

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-04-30T14:10:46Z

CodSpeed Instrumentation Performance Report

Merging #10727 will not alter performance

_{Comparing c/04-30-fix_linter_fix_false_positive_in_react_exhaustive_deps (c9575f6) with main (62843e6)}

Summary

✅ 36 untouched benchmarks

camc314 · 2025-04-30T14:24:28Z

Merge activity

Apr 30, 10:24 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 30, 10:24 AM EDT: camc314 added this pull request to the Graphite merge queue.
Apr 30, 10:44 AM EDT: Merged by the Graphite merge queue.

Fix React exhaustive-deps rule to correctly handle useCallback references This PR fixes the `exhaustive-deps` rule to no longer consider `useCallback` as a stable value, which was causing incorrect linting behavior. The change: 1. Removes `useCallback` from the stable value check, as it should not be treated like `useRef` 2. Updates tests to reflect this change by: - Commenting out tests that would cause infinite loops at runtime - Uncommenting a test case that should now pass - Adding a test case for the specific issue reported in #9788 closes #9788  ## Summary by CodeRabbit - **Bug Fixes** - Improved handling of React hooks by updating which hooks are recognized as stable, specifically adjusting support for useCallback. - **Tests** - Updated test coverage: disabled tests for unsupported recursive useCallback cases, enabled a nested callback test, and added a new test case related to a known issue.

github-actions bot added the A-linter Area - Linter label Apr 30, 2025

github-actions bot added the C-bug Category - Bug label Apr 30, 2025

camc314 marked this pull request as ready for review April 30, 2025 14:05

camc314 marked this pull request as draft April 30, 2025 14:06

camc314 force-pushed the c/04-30-fix_linter_fix_false_positive_in_react_exhaustive_deps branch from d5099d6 to 1973e48 Compare April 30, 2025 14:10

camc314 marked this pull request as ready for review April 30, 2025 14:10

camc314 force-pushed the c/04-30-fix_linter_fix_false_positive_in_react_exhaustive_deps branch from 1973e48 to a7067db Compare April 30, 2025 14:14

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025

graphite-app bot force-pushed the c/04-30-fix_linter_fix_false_positive_in_react_exhaustive_deps branch from a7067db to c9575f6 Compare April 30, 2025 14:40

graphite-app bot merged commit c9575f6 into main Apr 30, 2025
26 checks passed

graphite-app bot deleted the c/04-30-fix_linter_fix_false_positive_in_react_exhaustive_deps branch April 30, 2025 14:44

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025

oxc-bot mentioned this pull request May 2, 2025

release(oxlint): v0.16.9 #10765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter): fix false positive in react/exhaustive deps #10727

fix(linter): fix false positive in react/exhaustive deps #10727

camc314 commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

camc314 commented Apr 30, 2025

Uh oh!

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codspeed-hq bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

camc314 commented Apr 30, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(linter): fix false positive in react/exhaustive deps #10727

fix(linter): fix false positive in react/exhaustive deps #10727

Conversation

camc314 commented Apr 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Apr 30, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codspeed-hq bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10727 will not alter performance

Summary

Uh oh!

camc314 commented Apr 30, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codspeed-hq bot commented Apr 30, 2025 •

edited

Loading

camc314 commented Apr 30, 2025 •

edited by graphite-app bot

Loading