-
-
Notifications
You must be signed in to change notification settings - Fork 781
fix(editor): activate extension when astro files are opened too #10725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): activate extension when astro files are opened too #10725
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
WalkthroughThe change updates the VSCode extension's activation events to include support for the "astro" language. Now, the extension will activate when files of either the Svelte or Astro languages are opened or edited. No other modifications to functionality, commands, configuration, or dependencies were made. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
editors/vscode/package.json (1)
37-37: Enable Astro activation event
Adding"onLanguage:astro"triggers activation for Astro files as intended. Please verify that"astro"matches VS Code’s built-in language ID, and consider updating the README or extension documentation to mention Astro support.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
editors/vscode/package.json(1 hunks)
🔇 Additional comments (1)
editors/vscode/package.json (1)
36-36: Enable Svelte activation event
Including"onLanguage:svelte"correctly ensures the extension activates when opening Svelte files.
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for activating the extension when working with Astro language files in VSCode. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
3dc5327 to
0931bf9
Compare
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for activating the extension when working with Astro language files in VSCode. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
0931bf9 to
4ee95ec
Compare

Summary by CodeRabbit