fix(linter): mark isNan and isFinite as dangerous fixes in unicorn/prefer-number-properties
#10706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
changed the title
isNan and isFinite as dangerous fixes in unicorn/prefer-number-propertiesisNan and isFinite as dangerous fixes in unicorn/prefer-number-properties
CodSpeed Instrumentation Performance ReportMerging #10706 will not alter performanceComparing Summary
|
Member
Author
|
There are some more fixes, did not really read the file 👀 EDIT: wanted to create a new function but got stuck with the param hints and my broken rust-analyzer :/ |
Sysix
force-pushed
the
04-29-fix_linter_mark_isnan_and_isfinite_as_dangerous_fixes_in_unicorn_prefer-number-properties_
branch
from
7e05139 to
93a7968
Compare
camc314
approved these changes
Apr 30, 2025
Contributor
camc314
left a comment
camc314
left a comment
There was a problem hiding this comment.
i wonder wheter it's work adding an api like
ctx.diagnostic_with_fix_kind(diagnostic, FixKind::Dangerous, | fixer | {} )
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
…rn/prefer-number-properties` (#10706) I merged after I read about the `parse*` functions. The `isFinite` and `isNaN` should be dangerous fixes: ``` isFinite("0"); // true; coerced to number 0 Number.isFinite("0"); // false isFinite(null); // true; coerced to number 0 Number.isFinite(null); // false ``` https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite > As opposed to the global [isNaN()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN) function, the Number.isNaN() method doesn't force-convert the parameter to a number. This makes it safe to pass values that would normally convert to [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN) but aren't actually the same value as [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN). This also means that only values of the Number type that are also [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN) return true. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN
graphite-app
bot
force-pushed
the
04-29-fix_linter_mark_isnan_and_isfinite_as_dangerous_fixes_in_unicorn_prefer-number-properties_
branch
from
93a7968 to
0ee15cd
Compare
…rn/prefer-number-properties` (#10706) I merged after I read about the `parse*` functions. The `isFinite` and `isNaN` should be dangerous fixes: ``` isFinite("0"); // true; coerced to number 0 Number.isFinite("0"); // false isFinite(null); // true; coerced to number 0 Number.isFinite(null); // false ``` https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite > As opposed to the global [isNaN()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN) function, the Number.isNaN() method doesn't force-convert the parameter to a number. This makes it safe to pass values that would normally convert to [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN) but aren't actually the same value as [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN). This also means that only values of the Number type that are also [NaN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN) return true. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN
camc314
force-pushed
the
04-29-fix_linter_mark_isnan_and_isfinite_as_dangerous_fixes_in_unicorn_prefer-number-properties_
branch
from
0ee15cd to
a88e349
Compare
graphite-app
bot
deleted the
04-29-fix_linter_mark_isnan_and_isfinite_as_dangerous_fixes_in_unicorn_prefer-number-properties_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged after I read about the
parse*functions.The
isFiniteandisNaNshould be dangerous fixes:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN