Skip to content

fix(langage_server): fix initialize nested configs #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Apr 29, 2025
Merged

fix(langage_server): fix initialize nested configs #10698

graphite-app merged 1 commit into from
Apr 29, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Apr 29, 2025

No description provided.

@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Apr 29, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Apr 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 29, 2025
@Sysix Sysix marked this pull request as ready for review April 29, 2025 13:35
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 29, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10698 will not alter performance

Comparing 04-29-fix_langage_server_fix_initialize_nested_configs (46665bd) with main (06f796f)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Apr 29, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-29-fix_langage_server_fix_initialize_nested_configs branch from 8f76d5e to 46665bd Compare April 29, 2025 14:08
@graphite-app graphite-app bot merged commit 46665bd into main Apr 29, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-29-fix_langage_server_fix_initialize_nested_configs branch April 29, 2025 14:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@Sysix Sysix mentioned this pull request Apr 30, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Apr 30, 2025
@Sysix
test(language_server): add test for init_nested_configs (#10728)
5a709ad 
Added tests for the bug in #10698
@oxc-bot oxc-bot mentioned this pull request May 2, 2025
Merged
@Sysix Sysix mentioned this pull request May 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314