fix(linter): false positive in eslint/curly on windows #10671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
changed the title
camc314
force-pushed
the
c/04-28-fix_linter_false_positive_in_curly_on_windows
branch
from
789929a to
1cb8568
Compare
CodSpeed Instrumentation Performance ReportMerging #10671 will not alter performanceComparing Summary
|
Member
Merge activity
|
### TL;DR Fixed a false positive in the `curly` eslint rule when running on windows (`CRLF` line endings) ### What changed? since `\r\n` is two chars, `get_next_char_offset` was (incorrectly) returning a new line at the start of the string. Now, it checks for the `\r\n` pattern, to determine how many chars to skip (1 or 2) fixes #9600
graphite-app
bot
force-pushed
the
c/04-28-fix_linter_false_positive_in_curly_on_windows
branch
from
1cb8568 to
c89da93
Compare
graphite-app
bot
deleted the
c/04-28-fix_linter_false_positive_in_curly_on_windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed a false positive in the
curlyeslint rule when running on windows (CRLFline endings)What changed?
since
\r\nis two chars,get_next_char_offsetwas (incorrectly) returning a new line at the start of the string. Now, it checks for the\r\npattern, to determine how many chars to skip (1 or 2)fixes #9600