Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Apr 28, 2025

when working on #10667, i noticed these tests were missing from our suite.

this PR ports over the tests and fixes them

typescript/eslint PR typescript-eslint/typescript-eslint#10315

Copy link
Contributor Author

camc314 commented Apr 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 28, 2025
@camc314 camc314 marked this pull request as ready for review April 28, 2025 14:06
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10668 will not alter performance

Comparing c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type_with_satisfies_ (746b318) with main (cce1043)

Summary

✅ 36 untouched benchmarks

@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type_with_satisfies_ branch from c3db52a to 67b4b40 Compare April 28, 2025 14:47
@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type branch from 263af6d to 6f71d12 Compare April 28, 2025 14:47
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
Copy link
Member

Boshen commented Apr 28, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type branch from 6f71d12 to a84af09 Compare April 28, 2025 15:23
graphite-app bot pushed a commit that referenced this pull request Apr 28, 2025
…pe with `satisfies` (#10668)

when working on #10667, i noticed these tests were missing from our suite.

this PR ports over the tests and fixes them

typescript/eslint PR typescript-eslint/typescript-eslint#10315
@graphite-app graphite-app bot force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type_with_satisfies_ branch from 67b4b40 to cb58ae1 Compare April 28, 2025 15:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@shulaoda shulaoda force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type branch from a84af09 to cce1043 Compare April 29, 2025 02:48
Base automatically changed from c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type to main April 29, 2025 02:54
…pe with `satisfies` (#10668)

when working on #10667, i noticed these tests were missing from our suite.

this PR ports over the tests and fixes them

typescript/eslint PR typescript-eslint/typescript-eslint#10315
@graphite-app graphite-app bot force-pushed the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type_with_satisfies_ branch from cb58ae1 to 746b318 Compare April 29, 2025 02:54
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app graphite-app bot merged commit 746b318 into main Apr 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/04-28-fix_linter_false_positive_in_typescript_explicit-function-return-type_with_satisfies_ branch April 29, 2025 04:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants