Skip to content

feat(linter): report vars only used as types #10664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Apr 28, 2025
Merged

feat(linter): report vars only used as types #10664

graphite-app merged 1 commit into from
Apr 28, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Apr 28, 2025 •
edited
Loading

closes #8488

I ported accross the additional tests added in https://github.com/typescript-eslint/typescript-eslint/pull/9330/files, then fixed the resulting test cases

@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Apr 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Apr 28, 2025
@camc314 camc314 force-pushed the c/04-28-feat_linter_report_vars_only_used_as_types branch from f775767 to 25a8b86 Compare April 28, 2025 12:00
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10664 will not alter performance

Comparing c/04-28-feat_linter_report_vars_only_used_as_types (387af3a) with main (374e19e)

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A

@camc314 camc314 marked this pull request as ready for review April 28, 2025 12:04
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Apr 28, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camc314
feat(linter): report vars only used as types (#10664)
387af3a 
closes #8488

I ported accross the additional tests added in https://github.com/typescript-eslint/typescript-eslint/pull/9330/files, then fixed the resulting test cases
@graphite-app graphite-app bot force-pushed the c/04-28-feat_linter_report_vars_only_used_as_types branch from 25a8b86 to 387af3a Compare April 28, 2025 13:10
@graphite-app graphite-app bot merged commit 387af3a into main Apr 28, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/04-28-feat_linter_report_vars_only_used_as_types branch April 28, 2025 13:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@camc314 camc314 mentioned this pull request Apr 28, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(linter): enhance no-unused-vars

3 participants

@camc314 @Boshen