Skip to content

fix(linter): false positive in react/jsx-curly-brace-presence #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Apr 28, 2025
Merged

fix(linter): false positive in react/jsx-curly-brace-presence #10663

graphite-app merged 1 commit into from
Apr 28, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Apr 28, 2025 •
edited
Loading

fixes #9123

@camc314 camc314 mentioned this pull request Apr 28, 2025
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Apr 28, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 28, 2025
@camc314 camc314 marked this pull request as ready for review April 28, 2025 10:57
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10663 will not alter performance

Comparing c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence (374e19e) with main (e7c2b32)

Summary

✅ 36 untouched benchmarks

@camc314 camc314 force-pushed the c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence branch from 7964d91 to fd88edb Compare April 28, 2025 11:14
@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch from 172805e to 8d346e4 Compare April 28, 2025 11:14
@camc314 camc314 force-pushed the c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence branch from fd88edb to fe9e2e2 Compare April 28, 2025 11:57
@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch from 8d346e4 to 64b885f Compare April 28, 2025 11:57
@camc314 camc314 force-pushed the c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence branch from fe9e2e2 to b18cbe4 Compare April 28, 2025 11:58
@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch from 64b885f to 87a0e19 Compare April 28, 2025 11:58
@camc314 camc314 force-pushed the c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence branch from b18cbe4 to e0f54d1 Compare April 28, 2025 12:01
@camc314 camc314 force-pushed the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch from 87a0e19 to 01b52d1 Compare April 28, 2025 12:01
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Apr 28, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence branch from e0f54d1 to 5156822 Compare April 28, 2025 13:00
@graphite-app graphite-app bot force-pushed the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch from 01b52d1 to 374e19e Compare April 28, 2025 13:01
Base automatically changed from c/04-28-chore_linter_update_test_cases_for_react_jsx-curly-brace-presence to main April 28, 2025 13:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@graphite-app graphite-app bot merged commit 374e19e into main Apr 28, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/04-28-fix_linter_false_positive_in_react_jsx-curly-brace-presence branch April 28, 2025 13:10
@camc314 camc314 mentioned this pull request Apr 28, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: react/jsx-curly-brace-presence false positive when using template strings to avoid escape of ' and "

3 participants

@camc314 @Boshen