Skip to content

test(language_server): skip slow test #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
overlookmotel merged 1 commit into from
Apr 28, 2025
Merged

test(language_server): skip slow test #10658

overlookmotel merged 1 commit into from
Apr 28, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 28, 2025 •
edited
Loading

Temporary solution for #10657. Disable this test until we can make it faster.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Apr 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 28, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 28, 2025 09:32
@overlookmotel overlookmotel mentioned this pull request Apr 28, 2025
Closed
@overlookmotel
Copy link
Member Author

overlookmotel commented Apr 28, 2025

This reduces time to run "CI / Test (ubuntu-latest)" from 11 mins to 1 min.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10658 will not alter performance

Comparing 04-28-test_language_server_skip_slow_test (69129c2) with main (a47ccf2)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen requested a review from Sysix April 28, 2025 09:39
@overlookmotel
Copy link
Member Author

overlookmotel commented Apr 28, 2025 •
edited
Loading

I'm going to merge this as this test is slowing down merging other PRs.

@overlookmotel overlookmotel merged commit fd18aaa into main Apr 28, 2025
30 of 31 checks passed
@overlookmotel overlookmotel deleted the 04-28-test_language_server_skip_slow_test branch April 28, 2025 09:39
Boshen added a commit that referenced this pull request Apr 28, 2025
@Boshen
Revert "test(language_server): skip slow test (#10658)"
fe00b57 
This reverts commit fd18aaa.
@overlookmotel overlookmotel mentioned this pull request Apr 28, 2025
Merged
@oxc-bot oxc-bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sysix Sysix Awaiting requested review from Sysix Sysix is a code owner

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel