Skip to content

feat(linter): add unicorn/consistent-assert rule #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camc314 merged 6 commits into from
Apr 28, 2025
Merged

feat(linter): add unicorn/consistent-assert rule #10653

camc314 merged 6 commits into from
Apr 28, 2025
+565 −44

Conversation

@hakshu25
Copy link
Contributor

@hakshu25 hakshu25 commented Apr 28, 2025 •
edited
Loading

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-linter Area - Linter label Apr 28, 2025
@hakshu25 hakshu25 changed the title Feat/add-unicorn-consistent-assert-rule feat(linter): add unicorn/consistent-assert rule Apr 28, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Apr 28, 2025
@camc314 camc314 marked this pull request as ready for review April 28, 2025 08:03
@camc314 camc314 marked this pull request as draft April 28, 2025 08:03
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10653 will create unknown performance changes

Comparing hakshu25:feat/add-unicorn-consistent-assert-rule (b53ab44) with main (fd18aaa)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.2 ms N/A
🆕 formatter[antd.js] N/A 709.7 ms N/A
🆕 formatter[react.development.js] N/A 8 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.4 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.1 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[checker.ts] N/A 14.4 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 294 µs N/A
🆕 mangler[typescript.js] N/A 39.5 ms N/A
🆕 minifier[antd.js] N/A 163.5 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 287.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@hakshu25 hakshu25 force-pushed the feat/add-unicorn-consistent-assert-rule branch from 413112a to b48840d Compare April 28, 2025 08:13
@hakshu25 hakshu25 marked this pull request as ready for review April 28, 2025 08:14
camc314
camc314 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions github-actions bot added the A-cli Area - CLI label Apr 28, 2025
@hakshu25
Copy link
Contributor Author

hakshu25 commented Apr 28, 2025

@camc314
There were some errors in the CI, I fixed them.
Please re-review.

@camc314 camc314 merged commit eac205f into oxc-project:main Apr 28, 2025
25 checks passed
@oxc-bot oxc-bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hakshu25 @camc314