Skip to content

fix(language_server): Temporary ignore tests that panic on Windows #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leaysgur merged 1 commit into from
Apr 24, 2025
Merged

fix(language_server): Temporary ignore tests that panic on Windows #10583

leaysgur merged 1 commit into from
Apr 24, 2025

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Apr 24, 2025 •
edited
Loading

https://github.com/oxc-project/oxc/actions/runs/14632818437/job/41058127622

failures:

---- worker::tests::test_get_root_uri stdout ----

thread 'worker::tests::test_get_root_uri' panicked at crates\oxc_language_server\src\worker.rs:467:51:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- worker::tests::test_is_responsible stdout ----

thread 'worker::tests::test_is_responsible' panicked at crates\oxc_language_server\src\worker.rs:476:51:
called `Option::unwrap()` on a `None` value


failures:
    worker::tests::test_get_root_uri
    worker::tests::test_is_responsible

I'm not sure but maybe path(/foo/bar) is invalid format on Windows.

So I decided to ignore it for now.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Apr 24, 2025
@leaysgur leaysgur marked this pull request as ready for review April 24, 2025 08:12
@leaysgur
Copy link
Member Author

leaysgur commented Apr 24, 2025

CC: @Boshen , @Sysix

Once CI passes, I will merge it anyway and open issue for this.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10583 will not alter performance

Comparing disable-tests-panics-on-windows (64cc0aa) with main (f6c6969)

Summary

✅ 36 untouched benchmarks

@leaysgur leaysgur merged commit 91ce77a into main Apr 24, 2025
34 checks passed
@leaysgur leaysgur deleted the disable-tests-panics-on-windows branch April 24, 2025 08:23
@leaysgur leaysgur mentioned this pull request Apr 24, 2025
Closed
@ValentinGurkov ValentinGurkov mentioned this pull request Apr 24, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request Apr 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leaysgur