fix(parser,linter): consider typescript declarations for named exports #10532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Instrumentation Performance ReportMerging #10532 will not alter performanceComparing Summary
|
ulrichstark
changed the title
Member
|
I'll need to recall the reason for skipping typescript declarations (including merge declarations). |
ulrichstark
force-pushed
the
fix-missing-named-exports-of-typescript-declarations
branch
from
743329a to
578af74
Compare
Boshen
reviewed
Apr 25, 2025
Member
Probably yes, although it complicates semantic checks :-/ |
ulrichstark
deleted the
fix-missing-named-exports-of-typescript-declarations
branch
This was referenced Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only VariableDeclaration, FunctionDeclaration and ClassDeclaration were considered when collecting named export declarations for the module record. Now the parser also considers TSTypeAliasDeclaration, TSInterfaceDeclaration, TSEnumDeclaration, TSImportEqualsDeclaration and TSModuleDeclaration named export declarations of the module.
Maybe the other
decl.declaration.is_typescript_syntax()check inmodule_record.rsalso needs to be removed?Closes #10318
Closes #10556