Skip to content

perf(linter): replace phf_set with array for ATTRIBUTE_TAGS_MAP #10498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Apr 18, 2025
Merged

perf(linter): replace phf_set with array for ATTRIBUTE_TAGS_MAP #10498

graphite-app merged 1 commit into from
Apr 18, 2025

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Apr 18, 2025 •
edited
Loading

Related to #10076

@github-actions github-actions bot added the A-linter Area - Linter label Apr 18, 2025
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Apr 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Apr 18, 2025
@shulaoda shulaoda changed the title perf(linter): replace phf_set with array for ATTRIBUTE_TAGS_MAP perf(linter): replace phf_set with array for ATTRIBUTE_TAGS_MAP Apr 18, 2025
@shulaoda shulaoda marked this pull request as ready for review April 18, 2025 17:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 18, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-19-perf_linter_replace_phf_set_with_array_for_attribute_tags_map branch from 83928d0 to 0a4f9d9 Compare April 18, 2025 17:37
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 18, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10498 will not alter performance

Comparing 04-19-perf_linter_replace_phf_set_with_array_for_attribute_tags_map (0a4f9d9) with main (cfdfa2e)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 0a4f9d9 into main Apr 18, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-19-perf_linter_replace_phf_set_with_array_for_attribute_tags_map branch April 18, 2025 17:40
@shulaoda
Copy link
Member Author

shulaoda commented Apr 18, 2025 •
edited
Loading

Graphite's Merge when ready did not recognize the reviewer, causing the PR to merge unexpectedly. 😰
Could you help me review it again? @camc314

@shulaoda shulaoda requested a review from camc314 April 18, 2025 18:24
camc314
camc314 reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shulaoda shulaoda mentioned this pull request Apr 19, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Apr 20, 2025
@shulaoda
revert(linter): revert incorrect perf in react/no-unknown-property (#…
4fda4c5 
…10508)

Related to #10498, #10500, #10501

I benchmarked it incorrectly, which led to a flawed conclusion for large datasets. See #10076 for more details.
@oxc-bot oxc-bot mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 left review comments

Assignees

No one assigned

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shulaoda @camc314