How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

CodSpeed Instrumentation Performance Report

Merging #10494 will not alter performance

_{Comparing huangtiandi1999:fix/linter/no-else-return (078a35f) with main (0ab2cb4)}

Summary

✅ 36 untouched benchmarks

This does not look efficient. Can you try to use the span of BlockStatement?

do you mean modified like this?

- ctx.comments().iter().find()
+ ctx.comments_range(block.span.start..block.span.end).find()

This does not look efficient. Can you try to use the span of BlockStatement?

do you mean modified like this?

- ctx.comments().iter().find()
+ ctx.comments_range(block.span.start..block.span.end).find()

Sorry that I did not explain clearly. I mean that you don't even need to access comments, return span of BlockStatement is enough because that BlockStatement always contains comments. Note that BlockStatement's span contains { and }, you need to exclude them.

Hi @Dunqing
I have updated the replacement_span to use the span of BlockStatement and adjusted the related auto-fix test cases. Could you please review the changes when you have a moment?