fix(linter): config path resolution when path contains '..' syntax #10367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-cli
flowreaction
changed the title
flowreaction
changed the title
…d tests Improved the `find_oxlint_config` function to handle paths containing parent references ( ../.. syntax ) Added unit tests to verify behavior for valid and invalid config paths, including cases with parent directory references.
flowreaction
force-pushed
the
fix-parent-path-resolving
branch
from
a865ac2 to
703c5c4
Compare
Contributor
Author
oh ok, thanks for the link, i changed it and tests still pass so looks to be the better option 🙂 |
Contributor
Author
|
@Sysix, thanks for reviewing! What is the process from here on? I noticed that this Project uses graphite merge queues. So no need to merge from here right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the
find_oxlint_configfunction to handle paths containing parent references ( ../.. syntax )Added unit tests to verify behavior for valid and invalid config paths, including cases with parent directory references.