Skip to content

fix(linter): add check for plugin_name when applying LintFilterKind::Rule #10339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camchenry merged 1 commit into from
Apr 14, 2025
Merged

fix(linter): add check for plugin_name when applying LintFilterKind::Rule #10339

camchenry merged 1 commit into from
Apr 14, 2025

Conversation

@ulrichstark
Copy link
Contributor

@ulrichstark ulrichstark commented Apr 9, 2025

I noticed the missing check while working on #10259.

Before:

oxlint -A no-debugger # allows eslint/no-debugger
oxlint -A eslint/no-debugger # allows eslint/no-debugger
oxlint -A react/no-debugger # allows eslint/no-debugger
oxlint -A non-existent/no-debugger # allows eslint/no-debugger

After:

oxlint -A no-debugger # allows eslint/no-debugger
oxlint -A eslint/no-debugger # allows eslint/no-debugger
oxlint -A react/no-debugger
oxlint -A non-existent/no-debugger

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2025

CodSpeed Instrumentation Performance Report

Merging #10339 will degrade performances by 4.95%

Comparing ulrichstark:add-missing-check-for-plugin-name (5ff448e) with main (283e4c7)

Summary

❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ formatter[react.development.js] 41.5 µs 43.6 µs -4.95%

@Boshen Boshen requested a review from camchenry April 10, 2025 06:12
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 14, 2025

Merge activity

  • Apr 14, 5:08 PM UTC: @ulrichstark we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
@camchenry camchenry merged commit c1f5623 into oxc-project:main Apr 14, 2025
25 checks passed
@ulrichstark ulrichstark deleted the add-missing-check-for-plugin-name branch April 14, 2025 17:30
@oxc-bot oxc-bot mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulrichstark @camchenry