fix(linter): fix panic in multi byte char in TryFrom aria (#11350)

camc314 · camc314 · commit c91697ede746 · 2025-05-28T13:56:11.000Z
fixes #11348
diff --git a/crates/oxc_linter/src/globals.rs b/crates/oxc_linter/src/globals.rs
@@ -121,7 +121,7 @@ impl TryFrom<&str> for AriaProperty {
     type Error = ();
 
     fn try_from(value: &str) -> Result<Self, Self::Error> {
-        if value.len() < 9 || &value[..5] != "aria-" {
+        if value.len() < 9 || &value.as_bytes()[..5] != b"aria-" {
             return Err(());
         }
         match &value[5..] {
diff --git a/crates/oxc_linter/src/rules/react/no_unknown_property.rs b/crates/oxc_linter/src/rules/react/no_unknown_property.rs
@@ -757,6 +757,7 @@ fn test() {
 			      "#,
             None,
         ),
+        ("<t onCh&ntilde;nge/>", None),
     ];
 
     Tester::new(NoUnknownProperty::NAME, NoUnknownProperty::PLUGIN, pass, fail).test_and_snapshot();
diff --git a/crates/oxc_linter/src/snapshots/react_no_unknown_property.snap b/crates/oxc_linter/src/snapshots/react_no_unknown_property.snap
@@ -303,3 +303,10 @@ source: crates/oxc_linter/src/tester.rs
  3 &#9474;                       Hello, world!
    &#9584;&#9472;&#9472;&#9472;&#9472;
   help: Remove unknown property
+
+  &#9888; eslint-plugin-react(no-unknown-property): Unknown property found
+   &#9581;&#9472;[no_unknown_property.tsx:1:4]
+ 1 &#9474; <t onCh&ntilde;nge/>
+   &middot;    &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: Remove unknown property

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ impl TryFrom<&str> for AriaProperty {`
`121`	`121`	`type Error = ();`
`122`	`122`
`123`	`123`	`fn try_from(value: &str) -> Result<Self, Self::Error> {`
`124`		`- if value.len() < 9 \|\| &value[..5] != "aria-" {`
	`124`	`+ if value.len() < 9 \|\| &value.as_bytes()[..5] != b"aria-" {`
`125`	`125`	`return Err(());`
`126`	`126`	`}`
`127`	`127`	`match &value[5..] {`
-Original file line number
+Diff line change
 			      "#,
             None,
         ),
 +        ("<t onChñnge/>", None),
     ];
     Tester::new(NoUnknownProperty::NAME, NoUnknownProperty::PLUGIN, pass, fail).test_and_snapshot();
-Original file line number
+Diff line change
 │                       Hello, world!
    ╰────
   help: Remove unknown property
++
 +  ⚠ eslint-plugin-react(no-unknown-property): Unknown property found
 +   ╭─[no_unknown_property.tsx:1:4]
 + 1 │ <t onChñnge/>
 +   ·    ────────
 +   ╰────
 +  help: Remove unknown property