fix(linter): misplaced quote in jsx-curly-brace-presence test case (#11546)

camc314 · camc314 · commit b0e3e083ca9d · 2025-06-07T14:32:16.000Z
diff --git a/crates/oxc_linter/src/rules/react/jsx_curly_brace_presence.rs b/crates/oxc_linter/src/rules/react/jsx_curly_brace_presence.rs
@@ -915,12 +915,12 @@ fn test() {
         (r#"<App>{"foo 'bar'"}</App>"#, Some(json!([{ "children": "never" }]))),
         (
             r#"
-			        <App prop=""#,
+			        <App prop="" />"#,
             Some(json!(["always"])),
         ),
         (
             "
-			        <App prop='",
+			        <App prop='' />",
             Some(json!(["always"])),
         ),
         (
@@ -1186,9 +1186,9 @@ fn test() {
         ),
         (
             r#"
-			        <App prop=""#,
+			        <App prop="" />"#,
             r#"
-			        <App prop=""#,
+			        <App prop="" />"#,
             Some(json!(["always"])),
         ),
         (
diff --git a/crates/oxc_linter/src/snapshots/react_jsx_curly_brace_presence.snap b/crates/oxc_linter/src/snapshots/react_jsx_curly_brace_presence.snap
@@ -315,19 +315,23 @@ source: crates/oxc_linter/src/tester.rs
    &middot;       &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &times; Unterminated string
+  &#9888; eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    &#9581;&#9472;[jsx_curly_brace_presence.tsx:2:22]
  1 &#9474; 
- 2 &#9474;                     <App prop="
-   &middot;                               &#9472;
+ 2 &#9474;                     <App prop="" />
+   &middot;                               &#9472;&#9516;
+   &middot;                                &#9584;&#9472;&#9472; Wrap this value in curly braces
    &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: Wrap this value in curly braces
 
-  &times; Unterminated string
+  &#9888; eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    &#9581;&#9472;[jsx_curly_brace_presence.tsx:2:22]
  1 &#9474; 
- 2 &#9474;                     <App prop='
-   &middot;                               &#9472;
+ 2 &#9474;                     <App prop='' />
+   &middot;                               &#9472;&#9516;
+   &middot;                                &#9584;&#9472;&#9472; Wrap this value in curly braces
    &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: Wrap this value in curly braces
 
   &#9888; eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    &#9581;&#9472;[jsx_curly_brace_presence.tsx:4:19]

Original file line number	Diff line number	Diff line change
`@@ -915,12 +915,12 @@ fn test() {`
`915`	`915`	`(r#"<App>{"foo 'bar'"}</App>"#, Some(json!([{ "children": "never" }]))),`
`916`	`916`	`(`
`917`	`917`	`r#"`
`918`		`- <App prop=""#,`
	`918`	`+ <App prop="" />"#,`
`919`	`919`	`Some(json!(["always"])),`
`920`	`920`	`),`
`921`	`921`	`(`
`922`	`922`	`"`
`923`		`- <App prop='",`
	`923`	`+ <App prop='' />",`
`924`	`924`	`Some(json!(["always"])),`
`925`	`925`	`),`
`926`	`926`	`(`
`@@ -1186,9 +1186,9 @@ fn test() {`
`1186`	`1186`	`),`
`1187`	`1187`	`(`
`1188`	`1188`	`r#"`
`1189`		`- <App prop=""#,`
	`1189`	`+ <App prop="" />"#,`
`1190`	`1190`	`r#"`
`1191`		`- <App prop=""#,`
	`1191`	`+ <App prop="" />"#,`
`1192`	`1192`	`Some(json!(["always"])),`
`1193`	`1193`	`),`
`1194`	`1194`	`(`
-Original file line number
+Diff line change
    ·       ───────────
    ╰────
 -  × Unterminated string
 +  ⚠ eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    ╭─[jsx_curly_brace_presence.tsx:2:22]
 │
 - 2 │                     <App prop="
 -   ·                               ─
 + 2 │                     <App prop="" />
 +   ·                               ─┬
 +   ·                                ╰── Wrap this value in curly braces
    ╰────
 +  help: Wrap this value in curly braces
 -  × Unterminated string
 +  ⚠ eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    ╭─[jsx_curly_brace_presence.tsx:2:22]
 │
 - 2 │                     <App prop='
 -   ·                               ─
 + 2 │                     <App prop='' />
 +   ·                               ─┬
 +   ·                                ╰── Wrap this value in curly braces
    ╰────
 +  help: Wrap this value in curly braces
   ⚠ eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
    ╭─[jsx_curly_brace_presence.tsx:4:19]