test(linter): eslint/no-duplicate-imports shouldn't report the same span (#11324)

ulrichstark · web-flow · commit a404b2cbf528 · 2025-05-27T13:51:18.000+01:00
Adds a test for a bug that was unintentionally fixed by #11320. I also confirmed that the test would have failed before my original PR. Context: #11320 (comment)
diff --git a/crates/oxc_linter/src/rules/eslint/no_duplicate_imports.rs b/crates/oxc_linter/src/rules/eslint/no_duplicate_imports.rs
@@ -487,6 +487,13 @@ fn test() {
         export * from "os";"#,
             Some(serde_json::json!([{ "includeExports": true }])),
         ),
+        (
+            // Verifies that the error for the second line appears only once in the test snapshot.
+            // https://github.com/oxc-project/oxc/pull/11320#issuecomment-2912286528
+            r#"import type { PriorityDialogCustomClassNames, WeightDialogCustomClassNames } from "./HostEditDialogs";
+            import { PriorityDialog, WeightDialog } from "./HostEditDialogs";"#,
+            None,
+        ),
     ];
 
     Tester::new(NoDuplicateImports::NAME, NoDuplicateImports::PLUGIN, pass, fail)
diff --git a/crates/oxc_linter/src/snapshots/eslint_no_duplicate_imports.snap b/crates/oxc_linter/src/snapshots/eslint_no_duplicate_imports.snap
@@ -158,3 +158,14 @@ source: crates/oxc_linter/src/tester.rs
    &middot;                  &#9584;&#9472;&#9472; This export is duplicated
    &#9584;&#9472;&#9472;&#9472;&#9472;
   help: Merge the duplicated exports into a single export statement
+
+  &#9888; eslint(no-duplicate-imports): './HostEditDialogs' import is duplicated
+   &#9581;&#9472;[no_duplicate_imports.tsx:1:83]
+ 1 &#9474; import type { PriorityDialogCustomClassNames, WeightDialogCustomClassNames } from "./HostEditDialogs";
+   &middot;                                                                                   &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9516;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &middot;                                                                                            &#9584;&#9472;&#9472; Can be merged with this import
+ 2 &#9474;             import { PriorityDialog, WeightDialog } from "./HostEditDialogs";
+   &middot;                                                          &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9516;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &middot;                                                                   &#9584;&#9472;&#9472; This import is duplicated
+   &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: Merge the duplicated import into a single import statement

-Original file line number
+Diff line change
    ·                  ╰── This export is duplicated
    ╰────
   help: Merge the duplicated exports into a single export statement
++
 +  ⚠ eslint(no-duplicate-imports): './HostEditDialogs' import is duplicated
 +   ╭─[no_duplicate_imports.tsx:1:83]
 + 1 │ import type { PriorityDialogCustomClassNames, WeightDialogCustomClassNames } from "./HostEditDialogs";
 +   ·                                                                                   ─────────┬─────────
 +   ·                                                                                            ╰── Can be merged with this import
 + 2 │             import { PriorityDialog, WeightDialog } from "./HostEditDialogs";
 +   ·                                                          ─────────┬─────────
 +   ·                                                                   ╰── This import is duplicated
 +   ╰────
 +  help: Merge the duplicated import into a single import statement