fix(linter): false negative in no-restriced-imports with patterns and side effects (#11027)

camc314 · camc314 · commit 9a368be6201f · 2025-05-14T14:03:42.000Z
previously, when using `patterns` with side effects imports, the diagnostic would not be reported, this PR fixes it by checking the module name against patterns. fixes #10984
diff --git a/crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs b/crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs
@@ -1018,6 +1018,33 @@ impl NoRestrictedImports {
                 }
             }
         }
+
+        for (source, spans) in &side_effect_import_map {
+            let mut whitelist_found = false;
+            let mut err = None;
+            for pattern in &self.patterns {
+                match pattern.get_group_glob_result(source) {
+                    GlobResult::Whitelist => {
+                        whitelist_found = true;
+                        break;
+                    }
+                    GlobResult::Found => {
+                        err = Some(get_diagnostic_from_import_name_result_pattern(
+                            spans[0],
+                            source,
+                            &ImportNameResult::GeneralDisallowed,
+                            pattern,
+                        ));
+                    }
+                    GlobResult::None => {}
+                }
+            }
+            if !whitelist_found {
+                if let Some(err) = err {
+                    ctx.diagnostic(err);
+                }
+            }
+        }
     }
 
     fn report_import_name_allowed(&self, ctx: &LintContext<'_>, entry: &ImportEntry) {
@@ -3038,6 +3065,13 @@ fn test() {
                 serde_json::json!([{ "paths": [{ "name": "foo", "message": "foo is forbidden, use bar instead" }] }]),
             ),
         ),
+        // https://github.com/oxc-project/oxc/issues/10984
+        (
+            r"import 'foo'",
+            Some(
+                serde_json::json!([{ "patterns": [{ "group": ["foo"], "message": "foo is forbidden, use bar instead" }] }]),
+            ),
+        ),
     ];
 
     let fail_typescript = vec![
diff --git a/crates/oxc_linter/src/snapshots/eslint_no_restricted_imports.snap b/crates/oxc_linter/src/snapshots/eslint_no_restricted_imports.snap
@@ -815,6 +815,13 @@ source: crates/oxc_linter/src/tester.rs
    &#9584;&#9472;&#9472;&#9472;&#9472;
   help: foo is forbidden, use bar instead
 
+  &#9888; eslint(no-restricted-imports): 'foo' import is restricted from being used by a pattern.
+   &#9581;&#9472;[no_restricted_imports.tsx:1:1]
+ 1 &#9474; import 'foo'
+   &middot; &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: foo is forbidden, use bar instead
+
   &#9888; eslint(no-restricted-imports): 'import1' import is restricted from being used.
    &#9581;&#9472;[no_restricted_imports.tsx:1:1]
  1 &#9474; import foo from 'import1';

-Original file line number
+Diff line change
    ╰────
   help: foo is forbidden, use bar instead
 +  ⚠ eslint(no-restricted-imports): 'foo' import is restricted from being used by a pattern.
 +   ╭─[no_restricted_imports.tsx:1:1]
 + 1 │ import 'foo'
 +   · ────────────
 +   ╰────
 +  help: foo is forbidden, use bar instead
++
   ⚠ eslint(no-restricted-imports): 'import1' import is restricted from being used.
    ╭─[no_restricted_imports.tsx:1:1]
 │ import foo from 'import1';