fix(lsp): incorrect quick fix offset in vue files (#10742)

camc314 · camc314 · commit 98bcd5f46280 · 2025-05-01T14:41:26.000Z
fixes #10540
diff --git a/crates/oxc_language_server/src/snapshots/fixtures_linter_astro@debugger.astro.snap b/crates/oxc_language_server/src/snapshots/fixtures_linter_astro@debugger.astro.snap
@@ -12,7 +12,7 @@ related_information[0].location.range: Range { start: Position { line: 1, charac
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 1 }, end: Position { line: 1, character: 5 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 1, character: 0 }, end: Position { line: 1, character: 8 } } })
 
 
 code: "eslint(no-debugger)"
@@ -25,7 +25,7 @@ related_information[0].location.range: Range { start: Position { line: 10, chara
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 3 }, end: Position { line: 1, character: 7 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 10, character: 2 }, end: Position { line: 10, character: 10 } } })
 
 
 code: "eslint(no-debugger)"
@@ -38,7 +38,7 @@ related_information[0].location.range: Range { start: Position { line: 14, chara
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 3 }, end: Position { line: 1, character: 7 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 14, character: 2 }, end: Position { line: 14, character: 10 } } })
 
 
 code: "eslint(no-debugger)"
@@ -51,4 +51,4 @@ related_information[0].location.range: Range { start: Position { line: 18, chara
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 3 }, end: Position { line: 1, character: 7 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 18, character: 2 }, end: Position { line: 18, character: 10 } } })
diff --git a/crates/oxc_language_server/src/snapshots/fixtures_linter_svelte@debugger.svelte.snap b/crates/oxc_language_server/src/snapshots/fixtures_linter_svelte@debugger.svelte.snap
@@ -12,4 +12,4 @@ related_information[0].location.range: Range { start: Position { line: 1, charac
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 2 }, end: Position { line: 1, character: 2 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 1, character: 1 }, end: Position { line: 1, character: 10 } } })
diff --git a/crates/oxc_language_server/src/snapshots/fixtures_linter_vue@debugger.vue.snap b/crates/oxc_language_server/src/snapshots/fixtures_linter_vue@debugger.vue.snap
@@ -12,7 +12,7 @@ related_information[0].location.range: Range { start: Position { line: 5, charac
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 0, character: 5 }, end: Position { line: 1, character: 2 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 5, character: 4 }, end: Position { line: 5, character: 12 } } })
 
 
 code: "eslint(no-debugger)"
@@ -25,4 +25,4 @@ related_information[0].location.range: Range { start: Position { line: 10, chara
 severity: Some(Warning)
 source: Some("oxc")
 tags: None
-fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 2, character: 1 }, end: Position { line: 2, character: 10 } } })
+fixed: Some(FixedContent { message: Some("Remove the debugger statement"), code: "", range: Range { start: Position { line: 10, character: 4 }, end: Position { line: 10, character: 13 } } })
diff --git a/crates/oxc_linter/src/service/runtime.rs b/crates/oxc_linter/src/service/runtime.rs
@@ -612,8 +612,14 @@ impl Runtime {
                                             fix: message.fix.map(|fix| FixWithPosition {
                                                 content: fix.content,
                                                 span: SpanPositionMessage::new(
-                                                    offset_to_position(fix.span.start, source_text),
-                                                    offset_to_position(fix.span.end, source_text),
+                                                    offset_to_position(
+                                                        section.source.start + fix.span.start,
+                                                        source_text,
+                                                    ),
+                                                    offset_to_position(
+                                                        section.source.start + fix.span.end,
+                                                        source_text,
+                                                    ),
                                                 )
                                                 .with_message(
                                                     fix.message
