fix(linter): fix message in react/rules-of-hooks diagnostic (#11515)

camc314 · camc314 · commit 91855dff8348 · 2025-06-06T10:43:12.000Z
remove redundant `Message: ` from the diagnostic
diff --git a/crates/oxc_linter/src/rules/react/rules_of_hooks.rs b/crates/oxc_linter/src/rules/react/rules_of_hooks.rs
@@ -66,7 +66,7 @@ mod diagnostics {
 
     pub(super) fn async_component(span: Span, func_name: &str) -> OxcDiagnostic {
         OxcDiagnostic::warn(format!(
-            "message: `React Hook {func_name:?} cannot be called in an async function. "
+            "React Hook {func_name:?} cannot be called in an async function. "
         ))
         .with_label(span)
         .with_error_code_scope(SCOPE)
diff --git a/crates/oxc_linter/src/snapshots/react_rules_of_hooks.snap b/crates/oxc_linter/src/snapshots/react_rules_of_hooks.snap
@@ -585,15 +585,15 @@ source: crates/oxc_linter/src/tester.rs
    &middot;               &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "AsyncComponent" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "AsyncComponent" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:32]
  1 &#9474; 
  2 &#9474;                 async function AsyncComponent() {
    &middot;                                &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
  3 &#9474;                     useState();
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Anonymous" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "Anonymous" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:40]
  1 &#9474;     
  2 &#9474; &#9581;&#9472;&#9654;                 const AsyncComponent = async () => {
@@ -602,23 +602,23 @@ source: crates/oxc_linter/src/tester.rs
  5 &#9474;             
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Page" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "Page" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:32]
  1 &#9474; 
  2 &#9474;                 async function Page() {
    &middot;                                &#9472;&#9472;&#9472;&#9472;
  3 &#9474;                   useId();
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Page" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "Page" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:32]
  1 &#9474; 
  2 &#9474;                 async function Page() {
    &middot;                                &#9472;&#9472;&#9472;&#9472;
  3 &#9474;                   useId();
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "useAsyncHook" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "useAsyncHook" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:32]
  1 &#9474; 
  2 &#9474;                 async function useAsyncHook() {
@@ -682,7 +682,7 @@ source: crates/oxc_linter/src/tester.rs
  5 &#9474;                 }
    &#9584;&#9472;&#9472;&#9472;&#9472;
 
-  &#9888; eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "AsyncComponent" cannot be called in an async function.
+  &#9888; eslint-plugin-react-hooks(rules-of-hooks): React Hook "AsyncComponent" cannot be called in an async function.
    &#9581;&#9472;[rules_of_hooks.tsx:2:28]
  1 &#9474; 
  2 &#9474;             async function AsyncComponent() {

-Original file line number
+Diff line change
    ·               ──────────
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "AsyncComponent" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "AsyncComponent" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:32]
 │
 │                 async function AsyncComponent() {
    ·                                ──────────────
 │                     useState();
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Anonymous" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "Anonymous" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:40]
 │
 │ ╭─▶                 const AsyncComponent = async () => {
 │
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Page" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "Page" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:32]
 │
 │                 async function Page() {
    ·                                ────
 │                   useId();
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "Page" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "Page" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:32]
 │
 │                 async function Page() {
    ·                                ────
 │                   useId();
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "useAsyncHook" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "useAsyncHook" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:32]
 │
 │                 async function useAsyncHook() {
 │                 }
    ╰────
 -  ⚠ eslint-plugin-react-hooks(rules-of-hooks): message: `React Hook "AsyncComponent" cannot be called in an async function.
 +  ⚠ eslint-plugin-react-hooks(rules-of-hooks): React Hook "AsyncComponent" cannot be called in an async function.
    ╭─[rules_of_hooks.tsx:2:28]
 │
 │             async function AsyncComponent() {