fix(linter): fix panic when doing code gen on regexp (#10769)

camc314 · camc314 · commit 8c499c623be7 · 2025-05-03T00:31:29.000Z
fixes the panic in #10765 by providing the source text of the program to the code generator
diff --git a/crates/oxc_codegen/src/lib.rs b/crates/oxc_codegen/src/lib.rs
@@ -262,6 +262,7 @@ impl<'a> Codegen<'a> {
     /// NOTE: you must call [`Codegen::with_source_text`] before calling this method
     #[inline]
     pub fn print_expression(&mut self, expr: &Expression<'_>) {
+        debug_assert!(!self.source_text.is_empty());
         expr.print_expr(self, Precedence::Lowest, Context::empty());
     }
 }
diff --git a/crates/oxc_linter/src/fixer/mod.rs b/crates/oxc_linter/src/fixer/mod.rs
@@ -184,10 +184,10 @@ impl<'c, 'a: 'c> RuleFixer<'c, 'a> {
         self.new_fix(CompositeFix::Single(fix), message)
     }
 
-    #[expect(clippy::unused_self)]
     #[must_use]
     pub fn codegen(self) -> Codegen<'a> {
         Codegen::new()
+            .with_source_text(self.source_text())
             .with_options(CodegenOptions { single_quote: true, ..CodegenOptions::default() })
     }
 
diff --git a/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs b/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
@@ -553,6 +553,11 @@ fn test() {
         // `string.split()`
         (r#""&#129412;".split("")"#, r#"[..."&#129412;"]"#, None),
         (r#""foo bar baz".split("")"#, r#"[..."foo bar baz"]"#, None),
+        (
+            r"Array.from(path.matchAll(/\{([^{}?]+\??)\}/g))",
+            "[...path.matchAll(/\\{([^{}?]+\\??)\\}/g)]",
+            None,
+        ),
     ];
 
     Tester::new(PreferSpread::NAME, PreferSpread::PLUGIN, pass, fail)

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,7 @@ impl<'a> Codegen<'a> {`
`262`	`262`	/// NOTE: you must call [`Codegen::with_source_text`] before calling this method
`263`	`263`	`#[inline]`
`264`	`264`	`pub fn print_expression(&mut self, expr: &Expression<'_>) {`
	`265`	`+ debug_assert!(!self.source_text.is_empty());`
`265`	`266`	`expr.print_expr(self, Precedence::Lowest, Context::empty());`
`266`	`267`	`}`
`267`	`268`	`}`
Original file line number	Diff line number	Diff line change
`@@ -184,10 +184,10 @@ impl<'c, 'a: 'c> RuleFixer<'c, 'a> {`
`184`	`184`	`self.new_fix(CompositeFix::Single(fix), message)`
`185`	`185`	`}`
`186`	`186`
`187`		`- #[expect(clippy::unused_self)]`
`188`	`187`	`#[must_use]`
`189`	`188`	`pub fn codegen(self) -> Codegen<'a> {`
`190`	`189`	`Codegen::new()`
	`190`	`+ .with_source_text(self.source_text())`
`191`	`191`	`.with_options(CodegenOptions { single_quote: true, ..CodegenOptions::default() })`
`192`	`192`	`}`
`193`	`193`