fix(linter): false negative in no-restricted-imports (#11026)

camc314 · camc314 · commit 8c2cfbcb9f9e · 2025-05-14T14:03:42.000Z
in scenrio such as

```ts
import 'foo'
import { a } from 'b'
```

if `foo` was banned module, it wouldn't be reported as `module_record.import_entries.is_empty()` would not be true.

we now check if `import 'foo'` is included in `module_record.import_entries` to decide whether to add to side effects map
diff --git a/crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs b/crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs
@@ -993,7 +993,13 @@ impl NoRestrictedImports {
 
         for (source, requests) in &module_record.requested_modules {
             for request in requests {
-                if request.is_import && module_record.import_entries.is_empty() {
+                if request.is_import
+                    && (module_record.import_entries.is_empty()
+                        || module_record
+                            .import_entries
+                            .iter()
+                            .all(|entry| entry.statement_span != request.statement_span))
+                {
                     side_effect_import_map.entry(source).or_default().push(request.statement_span);
                 }
             }
@@ -3026,6 +3032,12 @@ fn test() {
         //         }]
         //     }])),
         // ),
+        (
+            r"import 'foo'; import {a} from 'b'",
+            Some(
+                serde_json::json!([{ "paths": [{ "name": "foo", "message": "foo is forbidden, use bar instead" }] }]),
+            ),
+        ),
     ];
 
     let fail_typescript = vec![
diff --git a/crates/oxc_linter/src/snapshots/eslint_no_restricted_imports.snap b/crates/oxc_linter/src/snapshots/eslint_no_restricted_imports.snap
@@ -808,6 +808,13 @@ source: crates/oxc_linter/src/tester.rs
    &#9584;&#9472;&#9472;&#9472;&#9472;
   help: foo is forbidden, use bar instead
 
+  &#9888; eslint(no-restricted-imports): 'foo' import is restricted from being used.
+   &#9581;&#9472;[no_restricted_imports.tsx:1:1]
+ 1 &#9474; import 'foo'; import {a} from 'b'
+   &middot; &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: foo is forbidden, use bar instead
+
   &#9888; eslint(no-restricted-imports): 'import1' import is restricted from being used.
    &#9581;&#9472;[no_restricted_imports.tsx:1:1]
  1 &#9474; import foo from 'import1';

-Original file line number
+Diff line change
    ╰────
   help: foo is forbidden, use bar instead
 +  ⚠ eslint(no-restricted-imports): 'foo' import is restricted from being used.
 +   ╭─[no_restricted_imports.tsx:1:1]
 + 1 │ import 'foo'; import {a} from 'b'
 +   · ─────────────
 +   ╰────
 +  help: foo is forbidden, use bar instead
++
   ⚠ eslint(no-restricted-imports): 'import1' import is restricted from being used.
    ╭─[no_restricted_imports.tsx:1:1]
 │ import foo from 'import1';