fix(linter): config path resolution when path contains '..' syntax (#10367)

flowreaction · web-flow · commit 4e1f536ab1d5 · 2025-04-14T18:25:19.000+08:00
Improved the `find_oxlint_config` function to handle paths containing
parent references ( ../.. syntax )
Added unit tests to verify behavior for valid and invalid config paths,
including cases with parent directory references.
diff --git a/apps/oxlint/src/lint.rs b/apps/oxlint/src/lint.rs
@@ -1,7 +1,7 @@
 use std::{
     env, fs,
     io::{ErrorKind, Write},
-    path::{Path, PathBuf},
+    path::{Path, PathBuf, absolute},
     time::Instant,
 };
 
@@ -475,7 +475,23 @@ impl LintRunner {
     // when no file is found, the default configuration is returned
     fn find_oxlint_config(cwd: &Path, config: Option<&PathBuf>) -> Result<Oxlintrc, String> {
         if let Some(config_path) = config {
-            let full_path = cwd.join(config_path);
+            let full_path = match absolute(cwd.join(config_path)) {
+                Ok(path) => path,
+                Err(e) => {
+                    let handler = GraphicalReportHandler::new();
+                    let mut err = String::new();
+                    handler
+                        .render_report(
+                            &mut err,
+                            &OxcDiagnostic::error(format!(
+                                "Failed to resolve config path {}: {e}",
+                                config_path.display()
+                            )),
+                        )
+                        .unwrap();
+                    return Err(err);
+                }
+            };
             return match Oxlintrc::from_file(&full_path) {
                 Ok(config) => Ok(config),
                 Err(diagnostic) => {
@@ -1076,6 +1092,35 @@ mod test {
         Tester::new().with_cwd("fixtures".into()).test_and_snapshot(args);
     }
 
+    #[test]
+    fn test_config_path_with_parent_references() {
+        let cwd = std::env::current_dir().unwrap();
+
+        // Test case 1: Invalid path that should fail
+        let invalid_config = PathBuf::from("child/../../fixtures/linter/eslintrc.json");
+        let result = LintRunner::find_oxlint_config(&cwd, Some(&invalid_config));
+        assert!(result.is_err(), "Expected config lookup to fail with invalid path");
+
+        // Test case 2: Valid path that should pass
+        let valid_config = PathBuf::from("fixtures/linter/eslintrc.json");
+        let result = LintRunner::find_oxlint_config(&cwd, Some(&valid_config));
+        assert!(result.is_ok(), "Expected config lookup to succeed with valid path");
+
+        // Test case 3: Valid path using parent directory (..) syntax that should pass
+        let valid_parent_config = PathBuf::from("fixtures/linter/../linter/eslintrc.json");
+        let result = LintRunner::find_oxlint_config(&cwd, Some(&valid_parent_config));
+        assert!(result.is_ok(), "Expected config lookup to succeed with parent directory syntax");
+
+        // Verify the resolved path is correct
+        if let Ok(config) = result {
+            assert_eq!(
+                config.path.file_name().unwrap().to_str().unwrap(),
+                "eslintrc.json",
+                "Config file name should be preserved after path resolution"
+            );
+        }
+    }
+
     #[test]
     fn test_cross_modules_with_nested_config() {
         let args = &[];
